Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect thrown exception when calling Path.GetFullPath with white-space #1030

Conversation

vbreuss
Copy link
Member

@vbreuss vbreuss commented Aug 22, 2023

Throw the correct ArgumentException instead of a NullReferenceException when calling Path.GetFullPath with a WhiteSpace string.

@vbreuss vbreuss changed the title fix: incorrect exception calling Path.GetFullPath with white-space fix: incorrect thrown exception when calling Path.GetFullPath with white-space Aug 23, 2023
@vbreuss vbreuss requested a review from fgreinacher August 24, 2023 18:08
Copy link
Contributor

@fgreinacher fgreinacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch 👍

@mergify mergify bot merged commit 00fb310 into TestableIO:main Aug 25, 2023
@vbreuss vbreuss deleted the topic/vb/throw-correct-exception-on-path-getfullpath branch August 25, 2023 09:45
@github-actions
Copy link

This is addressed in release v19.2.66.

@github-actions github-actions bot added the state: released Issues that are released label Aug 25, 2023
mergify bot referenced this pull request in Testably/Testably.Abstractions Aug 25, 2023
…19.2.67 (#390)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions)
| nuget | patch | `19.2.64` -> `19.2.67` |

---

### Release Notes

<details>
<summary>TestableIO/System.IO.Abstractions
(TestableIO.System.IO.Abstractions)</summary>

###
[`v19.2.67`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.67)

#### What's Changed

- fix: incorrectly thrown exception in `Directory.CreateSymbolicLink` by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1026](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1026)

**Full Changelog**:
TestableIO/System.IO.Abstractions@v19.2.66...v19.2.67

###
[`v19.2.66`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.66)

#### What's Changed

- chore(deps): update dependency githubactionstestlogger to v2.3.3 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1031](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1031)
- fix: incorrect thrown exception when calling `Path.GetFullPath` with
white-space by [@&#8203;vbreuss](https://togithub.com/vbreuss) in
[https://github.com/TestableIO/System.IO.Abstractions/pull/1030](https://togithub.com/TestableIO/System.IO.Abstractions/pull/1030)

**Full Changelog**:
TestableIO/System.IO.Abstractions@v19.2.64...v19.2.66

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Testably/Testably.Abstractions).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: released Issues that are released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants