Skip to content

Commit

Permalink
Fix GitHub workflow (#1075)
Browse files Browse the repository at this point in the history
### Summary
My previous PR's GitHub action does not save the binary properly for dev
board. I didn't notice until I merged my previous PR to the master and
fail the DBC-release. This PR is to fix that.
### Changelist 
`.github/workflows`

### Testing Done
running the action

### Resolved Issues
about

### Checklist
*Please change `[ ]` to `[x]` when you are ready.*
- [x] I have read and followed the code conventions detailed in
[README.md](../README.md) (*This will save time for both you and the
reviewer!*).
- [x] If this pull request is longer then **500** lines, I have provided
*explicit* justification in the summary above explaining why I *cannot*
break this up into multiple pull requests (*Small PR's are faster and
less painful for everyone involved!*).
  • Loading branch information
Jiajun-Huang authored Nov 12, 2023
1 parent 1764c77 commit 30fbfc1
Showing 1 changed file with 16 additions and 8 deletions.
24 changes: 16 additions & 8 deletions .github/workflows/master_cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,19 @@ jobs:
strategy:
fail-fast: false
matrix:
board:
- FSM
- PDM
- BMS
- DCM
- DIM
- f4dev
include:
- board: DIM
build_dir: firmware/thruna/DIM/DIM.elf
- board: FSM
build_dir: firmware/thruna/FSM/FSM.elf
- board: PDM
build_dir: firmware/thruna/PDM/PDM.elf
- board: DCM
build_dir: firmware/thruna/DCM/DCM.elf
- board: BMS
build_dir: firmware/thruna/BMS/BMS.elf
- board: f4dev
build_dir: firmware/dev/f4dev/f4dev.elf
container:
image: ubcformulaelectric/environment:latest
credentials:
Expand All @@ -37,9 +43,11 @@ jobs:
# Uploads .elf binary to Github Actions workflow
- name: Save built artifact
uses: actions/upload-artifact@v3
env:
BUILD_DIR: build_fw_deploy
with:
name: ${{ matrix.board }}.elf
path: ${{ env.BUILD_DIR }}/firmware/thruna/${{ matrix.board }}/${{ inputs.board }}.elf
path: ${{ env.BUILD_DIR }}/${{ matrix.build_dir }}

generate-dbc:
name: Call DBC Generation
Expand Down

0 comments on commit 30fbfc1

Please sign in to comment.