Fix GitHub workflow #1075
Merged
Fix GitHub workflow #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucien950
added
the
Build System/DevEx
Jiajun-Huang
force-pushed
the
jiajun/workflow_fix
branch
from
333c584 to
1f0f2a3
Compare
Lucien950
approved these changes
Nov 12, 2023
.github/workflows/master_cd.yml
Outdated
Comment on lines
9
to
10
|
|
||
|
|
.github/workflows/master_cd.yml
Outdated
Comment on lines
16
to
17
| env: | ||
| BUILD_DIR: build_fw_deploy |
There was a problem hiding this comment.
I don't think you need to do this, because build_dir is default in the build_binary action. If you need to specify it, add it at L46.
AmirTajaddodi
pushed a commit
that referenced
this pull request
Nov 18, 2023
### Summary My previous PR's GitHub action does not save the binary properly for dev board. I didn't notice until I merged my previous PR to the master and fail the DBC-release. This PR is to fix that. ### Changelist `.github/workflows` ### Testing Done running the action ### Resolved Issues about ### Checklist *Please change `[ ]` to `[x]` when you are ready.* - [x] I have read and followed the code conventions detailed in [README.md](../README.md) (*This will save time for both you and the reviewer!*). - [x] If this pull request is longer then **500** lines, I have provided *explicit* justification in the summary above explaining why I *cannot* break this up into multiple pull requests (*Small PR's are faster and less painful for everyone involved!*).
lehroatic
pushed a commit
that referenced
this pull request
Nov 22, 2023
### Summary My previous PR's GitHub action does not save the binary properly for dev board. I didn't notice until I merged my previous PR to the master and fail the DBC-release. This PR is to fix that. ### Changelist `.github/workflows` ### Testing Done running the action ### Resolved Issues about ### Checklist *Please change `[ ]` to `[x]` when you are ready.* - [x] I have read and followed the code conventions detailed in [README.md](../README.md) (*This will save time for both you and the reviewer!*). - [x] If this pull request is longer then **500** lines, I have provided *explicit* justification in the summary above explaining why I *cannot* break this up into multiple pull requests (*Small PR's are faster and less painful for everyone involved!*).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
My previous PR's GitHub action does not save the binary properly for dev board. I didn't notice until I merged my previous PR to the master and fail the DBC-release. This PR is to fix that.
Changelist
.github/workflowsTesting Done
running the action
Resolved Issues
about
Checklist
Please change
[ ]to[x]when you are ready.