Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Disable open wire check because we're getting module communication er…
…rors with it enabled (#1298) ### Changelist <!-- Give a list of the changes covered in this PR. This will help both you and the reviewer keep this PR within scope. --> Does what it says on the tin. ### Testing Done <!-- Outline the testing that was done to demonstrate the changes are solid. This could be unit tests, integration tests, testing on the car, etc. Include relevant code snippets, screenshots, etc as needed. --> Copy-pasted our testing today from slack: What we were seeing before this: - Talked to each module directly in isolation (setting ACCUMULATOR_NUM_SEGMENTS to 1). No issues on any segments from ISOSPI A or ISOSPI B. - Tested each individual cable in isolation, also no issues. - However, when we hooked up 3 modules we'd get communication error faults after ~10 seconds. I think once or twice we managed to get to 4 segments, but never 5 With this change: - Disabled open wire check. No idea why this would break anything. - After that, I could pretty reliably get up to 4 modules talking. 5 still work, but after rearranging the cables I found a configuration that did work. - Absolutely no idea whats going on here. Is there anything that would cause the communication to be unreliable? Maybe sketchy connector, noise, etc... I was able to run the battery for a few minutes without any communication faults (with open wire check disabled). --------- Co-authored-by: will-chaba <[email protected]>
- Loading branch information