Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake Cleanup #1328

Merged
merged 98 commits into from
Sep 26, 2024
Merged

CMake Cleanup #1328

merged 98 commits into from
Sep 26, 2024

Conversation

Lucien950
Copy link
Contributor

@Lucien950 Lucien950 commented Jul 22, 2024 •
edited by jira bot
Loading

Changelist

  • Consolidate configurations into presets FIRM-26, and make CI use those presets FIRM-27
  • Better CMake logs
  • Deploy mode, with optimized binaries, and dev mode with maximized debug symbols FIRM-22
    • Use CMAKE_BUILD_TYPE = deploy and dev to control optimization levels
  • Consistent capitalization and formatting of CMake syntax
  • Remove Littlefs FIRM-25
  • Modularization of CMake files, including moving dependencies, embedded.cmake, new stmlib.cmake, etc.
  • Convert from TARGET = deploy, tests to TARGET = binary, tests
  • Migrate to Arm, and remove heap_useNewlib (FIRM-74)

Testing Done

Resolved Tickets

Lucien950 added 28 commits July 15, 2024 23:37
@Lucien950
seperate toolchain configs
b57e98a
@Lucien950
moving things around
01b90f5
@Lucien950
more moving
31befb7
@Lucien950
more settings for cmake presets
2c6f71c
@Lucien950
idk what compelled me to do that
900c1e8
@Lucien950
turn off optional deps
65b0b85
@Lucien950
silly mistake in cmakepresets
030fdd5
@Lucien950
firmer checks
8860a56
@Lucien950
more guards
df26d6c
@Lucien950
more visibility for options
9f13cf1
@Lucien950
gcc temporary reversion
e3d4a98
@Lucien950
switch to target being binary/test
4c31157
@Lucien950
better logging from the firmware boards
537ab51
@Lucien950
function > path logging
771c042
@Lucien950
post commitinfo generate file log
b28f5f2
@Lucien950
seperate STM32cubemx cmake functionality
97b322a
@Lucien950
reformatting and commenting
f6ba425
@Lucien950
move few more functions around
e575acf
@Lucien950
deploy mode compiler flags
72de1f4
@Lucien950
idk why I need to do this?
dc0d333
@Lucien950
more embedded flags
b99a8a4
@Lucien950
new heap_useNewLib
1942438
@Lucien950
because of course
0564497
@Lucien950
some compiler flag adjustments
3732e40
@Lucien950
toolchain options
7ad8922
@Lucien950
link to nano.spacs as well
03d7580
@Lucien950
oops
4403eaf
@Lucien950
CI
d142e79
@Lucien950 Lucien950 self-assigned this Jul 22, 2024
AmirTajaddodi
AmirTajaddodi approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@AmirTajaddodi AmirTajaddodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Lucien950 Lucien950 merged commit 45a4efd into master Sep 26, 2024
27 checks passed
@Lucien950 Lucien950 deleted the cmake-cleanup-2024 branch September 26, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmirTajaddodi AmirTajaddodi AmirTajaddodi approved these changes

@liam-ilan liam-ilan Awaiting requested review from liam-ilan

Assignees

@Lucien950 Lucien950

Labels
Build System/DevEx Anything that affects Build System, IDE Integration, Github Actions, Code Deployment
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lucien950 @AmirTajaddodi