-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GPS watchdog and get data #1352
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1mackenziekyle
force-pushed
the
kyle-phi/gps-debug
branch
from
October 16, 2024 18:18
c5897fc
to
88f1baa
Compare
philam2001
force-pushed
the
kyle-phi/gps-debug
branch
from
October 17, 2024 00:53
88f1baa
to
5a8ffc2
Compare
philam2001
force-pushed
the
kyle-phi/gps-debug
branch
3 times, most recently
from
October 30, 2024 00:50
97055e7
to
d6be97e
Compare
philam2001
force-pushed
the
kyle-phi/gps-debug
branch
from
November 11, 2024 22:00
373b9ea
to
909928f
Compare
philam2001
force-pushed
the
kyle-phi/gps-debug
branch
2 times, most recently
from
November 24, 2024 19:46
951d70e
to
6149524
Compare
philam2001
force-pushed
the
kyle-phi/gps-debug
branch
from
November 29, 2024 17:42
9dbea9b
to
c771f61
Compare
Lucien950
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few suggestions
DJ90864
pushed a commit
that referenced
this pull request
Dec 7, 2024
### Changelist <!-- Give a list of the changes covered in this PR. This will help both you and the reviewer keep this PR within scope. --> - Enable GPS can messages that are used and are received by SBG, broadcast them, and enable sbg io - Rewrote rtos queue architecture in callback and in read function - No more watchdog or cpu timing issues ### Testing Done <!-- Outline the testing that was done to demonstrate the changes are solid. This could be unit tests, integration tests, testing on the car, etc. Include relevant code snippets, screenshots, etc as needed. --> - Ran HV and in drive state, extract SD data, stable, deterministic can messages received ### Resolved Tickets <!-- Link any tickets that this PR resolves. --> - [FIRM-14](https://ubcformulaelectric.atlassian.net/jira/software/c/projects/FIRM/boards/37?selectedIssue=FIRM-14) [FIRM-14]: https://ubcformulaelectric.atlassian.net/browse/FIRM-14?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Kyle Mackenzie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
Testing Done
Resolved Tickets