Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GPS watchdog and get data #1352

Merged
merged 15 commits into from
Nov 29, 2024
Merged

Fix GPS watchdog and get data #1352

merged 15 commits into from
Nov 29, 2024

Conversation

philam2001
Copy link
Contributor

@philam2001 philam2001 commented Oct 15, 2024

Changelist

  • Enable GPS can messages that are used and are received by SBG, broadcast them, and enable sbg io
  • Rewrote rtos queue architecture in callback and in read function
  • No more watchdog or cpu timing issues

Testing Done

  • Ran HV and in drive state, extract SD data, stable, deterministic can messages received

Resolved Tickets

@philam2001 philam2001 self-assigned this Oct 16, 2024
@philam2001 philam2001 added the Vehicle Controls Torque Vectoring, Regen, Brake/Drive Diffs label Oct 16, 2024
@philam2001 philam2001 force-pushed the kyle-phi/gps-debug branch 3 times, most recently from 97055e7 to d6be97e Compare October 30, 2024 00:50
@philam2001 philam2001 marked this pull request as ready for review November 7, 2024 18:14
@philam2001 philam2001 force-pushed the kyle-phi/gps-debug branch 2 times, most recently from 951d70e to 6149524 Compare November 24, 2024 19:46
@philam2001 philam2001 requested a review from Lucien950 November 28, 2024 21:57
Copy link
Contributor

@Lucien950 Lucien950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few suggestions

firmware/quadruna/VC/src/app/app_sbgEllipse.h Outdated Show resolved Hide resolved
firmware/shared/src/app/app_utils.h Show resolved Hide resolved
firmware/quadruna/VC/src/tasks.c Show resolved Hide resolved
@philam2001 philam2001 merged commit 10fed44 into master Nov 29, 2024
27 checks passed
@philam2001 philam2001 deleted the kyle-phi/gps-debug branch November 29, 2024 21:42
DJ90864 pushed a commit that referenced this pull request Dec 7, 2024
### Changelist 
<!-- Give a list of the changes covered in this PR. This will help both
you and the reviewer keep this PR within scope. -->

- Enable GPS can messages that are used and are received by SBG,
broadcast them, and enable sbg io
- Rewrote rtos queue architecture in callback and in read function
- No more watchdog or cpu timing issues

### Testing Done
<!-- Outline the testing that was done to demonstrate the changes are
solid. This could be unit tests, integration tests, testing on the car,
etc. Include relevant code snippets, screenshots, etc as needed. -->
- Ran HV and in drive state, extract SD data, stable, deterministic can
messages received
### Resolved Tickets
<!-- Link any tickets that this PR resolves. -->
-
[FIRM-14](https://ubcformulaelectric.atlassian.net/jira/software/c/projects/FIRM/boards/37?selectedIssue=FIRM-14)


[FIRM-14]:
https://ubcformulaelectric.atlassian.net/browse/FIRM-14?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: Kyle Mackenzie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Vehicle Controls Torque Vectoring, Regen, Brake/Drive Diffs
Development

Successfully merging this pull request may close these issues.

3 participants