Deinit sequences #1369
Merged
Deinit sequences #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kryptoish
requested review from
Lucien950,
Jugveer-Sandher,
AmirTajaddodi and
liam-ilan
Lucien950
previously requested changes
Oct 29, 2024
kryptoish
changed the title
kryptoish
changed the title
AmirTajaddodi
previously requested changes
Nov 15, 2024
| extern uint32_t __boot_code_start__; | ||
| extern uint32_t __boot_code_size__; | ||
|
|
||
| void modifyStackPointerAndStartApp(const uint32_t *address) |
There was a problem hiding this comment.
can you change the name of this from modifyingstackpointerandstartapp to io_bootloader_modifyingStackPointer
firmware/quadruna/BMS/CMakeLists.txt
Outdated
| @@ -167,6 +168,7 @@ elseif ("${TARGET}" STREQUAL "test") | |||
| "${CMAKE_CURRENT_SOURCE_DIR}/src/io/io_sd.h" | |||
| "${CMAKE_CURRENT_SOURCE_DIR}/src/io/io_bspdTest.h" | |||
| "${CMAKE_CURRENT_SOURCE_DIR}/src/io/io_bmsShdn.h" | |||
| "${CMAKE_CURRENT_SOURCE_DIR}/src/io/io_bootloader.h" | |||
There was a problem hiding this comment.
We dont need this in test compile
| @@ -152,6 +153,7 @@ elseif ("${TARGET}" STREQUAL "test") | |||
| "${CMAKE_CURRENT_SOURCE_DIR}/src/io/io_leds.h" | |||
| "${CMAKE_CURRENT_SOURCE_DIR}/src/io/io_switches.h" | |||
| "${CMAKE_CURRENT_SOURCE_DIR}/src/io/io_critShdn.h" | |||
| "${CMAKE_CURRENT_SOURCE_DIR}/src/io/io_bootloader.h" | |||
firmware/quadruna/FSM/CMakeLists.txt
Outdated
| @@ -157,6 +158,7 @@ elseif ("${TARGET}" STREQUAL "test") | |||
| "${CMAKE_CURRENT_SOURCE_DIR}/src/io/io_suspension.h" | |||
| "${CMAKE_CURRENT_SOURCE_DIR}/src/io/io_loadCell.h" | |||
| "${CMAKE_CURRENT_SOURCE_DIR}/src/io/io_fsmShdn.h" | |||
| "${CMAKE_CURRENT_SOURCE_DIR}/src/io/io_bootloader.h" | |||
kryptoish
force-pushed
the
krish/CRIT_Deinit_Sequence
branch
from
b52f110 to
b1b19ca
Compare
Jugveer-Sandher
requested changes
Jan 12, 2025
Jugveer-Sandher
approved these changes
Jan 18, 2025
kryptoish
force-pushed
the
krish/CRIT_Deinit_Sequence
branch
2 times, most recently
from
c15fb67 to
8b907d1
Compare
kryptoish
force-pushed
the
krish/CRIT_Deinit_Sequence
branch
from
c85ca9e to
500e579
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
De-initialized peripherals & interrupts for all boards (except VC). Changes only on quadruna.
Testing Done
Resolved Tickets