merge master #1416
Merged
merge master #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Changelist <!-- Give a list of the changes covered in this PR. This will help both you and the reviewer keep this PR within scope. --> ### Testing Done <!-- Outline the testing that was done to demonstrate the changes are solid. This could be unit tests, integration tests, testing on the car, etc. Include relevant code snippets, screenshots, etc as needed. --> ### Resolved Tickets <!-- Link any tickets that this PR resolves. -->
### Changelist - Added USB middleware flag to stm32 h7 and f4 binary building functions. - Setup USB Echo Program on F4 and H7 (H7 not tested due to clock misconfiguration). ### Testing Done - USB Device Appears as device when plugged into computer (f4dev). - Able to communicate with f4dev via pyusb (@setaremalekiii). - h7dev untested, to be done when clock configs fixed. - Ran subsequent `hw_usb` library on top of this one, usb comms working awesome. ### Resolved Tickets [FIRM-159](https://ubcformulaelectric.atlassian.net/browse/FIRM-159) [FIRM-159]: https://ubcformulaelectric.atlassian.net/browse/FIRM-159?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
### Changelist Calibrated the current sensor Error based on the data collected for both channels of the current sensor and for directions of current (charging & discharging) ### Testing Done Tested on the car and works amazing Here's the data and how the calibration works (done in excel) [50A Calibration Forward Current.xlsx](https://github.com/user-attachments/files/17836984/50A.Calibration.Forward.Current.xlsx) [50A Calibration Reverse Current.xlsx](https://github.com/user-attachments/files/17836986/50A.Calibration.Reverse.Current.xlsx) [400A Calibration Forward Current.xlsx](https://github.com/user-attachments/files/17836987/400A.Calibration.Forward.Current.xlsx) [400A Calibration Reverse Current.xlsx](https://github.com/user-attachments/files/17836988/400A.Calibration.Reverse.Current.xlsx) ### Resolved Tickets <!-- Link any tickets that this PR resolves. -->
### Changelist <!-- Give a list of the changes covered in this PR. This will help both you and the reviewer keep this PR within scope. --> - fully moves away from C++ - update docker cubemx for quintuna - cmakefile tweaks ### Testing Done <!-- Outline the testing that was done to demonstrate the changes are solid. This could be unit tests, integration tests, testing on the car, etc. Include relevant code snippets, screenshots, etc as needed. --> ### Resolved Tickets <!-- Link any tickets that this PR resolves. -->
### Changelist <!-- Give a list of the changes covered in this PR. This will help both you and the reviewer keep this PR within scope. --> - Changed structure of heartbeat monitor config. (see `firmware/shared/src/app/app_heartbeatMonitorBoard.h`) - Gives sturcture towards future app level refactor ### Testing Done <!-- Outline the testing that was done to demonstrate the changes are solid. This could be unit tests, integration tests, testing on the car, etc. Include relevant code snippets, screenshots, etc as needed. --> - fixed tests for all boards - adapted shared heartbeat monitor to new structure ### Resolved Tickets <!-- Link any tickets that this PR resolves. -->
### Changelist <!-- Give a list of the changes covered in this PR. This will help both you and the reviewer keep this PR within scope. --> ### Testing Done <!-- Outline the testing that was done to demonstrate the changes are solid. This could be unit tests, integration tests, testing on the car, etc. Include relevant code snippets, screenshots, etc as needed. --> ### Resolved Tickets <!-- Link any tickets that this PR resolves. --> admin hardmerge :)))))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
Testing Done
Resolved Tickets