Kevin/bms/imd decoding fix #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… discrepency that was causing frequency to be reported double after the initial fix
DJ90864
reviewed
Jan 14, 2025
| @@ -74,7 +74,7 @@ extern "C" | |||
| #define TIMx_FREQUENCY 512000000 | |||
| #define IWDG_RESET_FREQUENCY 5 | |||
| #define TASK1KHZ_STACK_SIZE 512 | |||
| #define TIM1_FREQUENCY 512000000 | |||
There was a problem hiding this comment.
@will-chaba "small bug left behind"
Cough Cough "IMD Quadruna never working" Cough Cough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
Changed the trigger source for tim1 from ti1fp2 to ti1fp1 since we switched the channels 1 and 2 functionality from thruna to quadruna. Also changed the user constants for the tim1 frequency to the value of the clk config.
Testing Done
Tested with function generator and oscilloscope to confirm readings were accurate.
Resolved Tickets
FIRM-221