Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all warnings in ncdap4 #2898

Merged
merged 11 commits into from
May 16, 2024
Merged

Fix all warnings in ncdap4 #2898

merged 11 commits into from
May 16, 2024

Conversation

ZedThree
Copy link
Contributor

No description provided.

@ZedThree
Copy link
Contributor Author

The failing tests here seem to be the same issue as #2897 ?

@ZedThree ZedThree mentioned this pull request Apr 8, 2024
Merged
ZedThree added 3 commits April 25, 2024 09:27
@ZedThree
Merge branch 'main' into silence-ncdap4-warnings
40b7cfc 
* main: (48 commits)
  Update release notes.
  Refactor macro _FillValue to NC_FillValue in support of Unidata#2858
  Remove appveyor config file.
  Add CI for a Windows Runner on Github Actions.
  Add cmake prefix path to appveyor config.
  Attempt to fix zlib-related error in appveyor.
  Correct typo.
  Remove check for libcurl unless it is necessary for required functionality.
  Rename the vendored strlcat symbol
  Fix conversion warnings in libdispatch
  Set flags to avoid warning messages if curl isn't found.
  Use modern cmake nomenclature for curl.
  Fix truncated-format warning in ncgen
  Fix some conversion warnings in ncgen3
  Fix some conversion warnings in ncgen3 generated files
  Regenerate ncgen3
  CMake: Add option to automatically regenerate ncgen3/ncgen
  Skip checking for duplicates if only one element in list
  Change format of backwards-loops
  Silence some conversion warnings in ncgen generated files
  ...
@ZedThree
Fix conversion warning in flag set/check/clear macros
54fb03e
@ZedThree
Merge branch 'main' into silence-ncdap4-warnings
c841dce 
* main:
  Modify CMakeLists.txt to honor CMAKE_INSTALL_MANDIR in support of Unidata#2920.
  Modify ncdump to print char-valued variables as utf8.
  removal of ftp and contrib site
  removal of ftp site
  removal of ftp and netcdf contrib site
  removal of ftp and netcdf contrib site
  comment
  ftp --> resources for sample data location
  ftp--> resources for sample data location
  CMake: Enable plugins on MinGW
  Reintroduce targets to allow for cmake-based netCDF-Fortran to find and linka gainst netCDF-C. Stop-gap measure until we can modify netCDF-Fortran to use a more modern approach.
  revert
  ckp
  test1
  debug1
@ZedThree
Copy link
Contributor Author

The failing tests are a bit odd, they're all failing in the Check cache stage:

Run ls ${HOME}/environments && ls ${HOME}/environments/1.14.3 && ls ${HOME}/environments/1.14.3/lib
ls: /Users/runner/environments: No such file or directory

Actually, the previous stage, Fetch HDF Cache has the issue:

Run actions/cache@v4
  with:
    path: ~/environments/1.14.3
    key: hdf5-macOS-1.14.3
    enableCrossOsArchive: false
    fail-on-cache-miss: false
    lookup-only: false
    save-always: false
  env:
    CFLAGS: -I/Users/runner/environments/1.14.3/include
    LDFLAGS: -L/Users/runner/environments/1.14.3/lib
    LD_LIBRARY_PATH: /Users/runner/environments/1.14.3/lib
    NETCDF_ENABLE_HDF4: --disable-hdf4
    NETCDF_ENABLE_HDF5: --disable-hdf5
    NETCDF_ENABLE_DAP: --enable-dap
    NETCDF_ENABLE_NCZARR: --enable-nczarr
Cache not found for input keys: hdf5-macOS-1.14.3

I don't see any different with one of the passing tests:

Run actions/cache@v4
  with:
    path: ~/environments/1.14.3
    key: hdf5-macOS-1.14.3
    enableCrossOsArchive: false
    fail-on-cache-miss: false
    lookup-only: false
    save-always: false
  env:
    CFLAGS: -I/Users/runner/environments/1.14.3/include
    LDFLAGS: -L/Users/runner/environments/1.14.3/lib
    LD_LIBRARY_PATH: /Users/runner/environments/1.14.3/lib
    NETCDF_ENABLE_HDF4: --disable-hdf4
    NETCDF_ENABLE_HDF5: --disable-hdf5
    NETCDF_ENABLE_DAP: --disable-dap
    NETCDF_ENABLE_NCZARR: --enable-nczarr
Cache Size: ~3 MB ([2](https://github.com/Unidata/netcdf-c/actions/runs/8829596088/job/24802177215?pr=2898#step:12:2)762444 B)
/usr/local/bin/gtar -xf /Users/runner/work/_temp/c[3](https://github.com/Unidata/netcdf-c/actions/runs/8829596088/job/24802177215?pr=2898#step:12:3)56a13a-8494-41a7-a326-5ffc5a9d0[4](https://github.com/Unidata/netcdf-c/actions/runs/8829596088/job/24802177215?pr=2898#step:12:4)2e/cache.tzst -P -C /Users/runner/work/netcdf-c/netcdf-c --delay-directory-restore --use-compress-program unzstd
Cache restored successfully
Cache restored from key: hdf[5](https://github.com/Unidata/netcdf-c/actions/runs/8829596088/job/24802177215?pr=2898#step:12:5)-macOS-1.14.3

This looks like a problem with CI, but I don't understand what's triggering it. I don't think it could be anything in this PR

@ZedThree
Merge branch 'main' into silence-ncdap4-warnings
12840ab 
* main:
  ftp --> resources
  Update release notes
  Convert the ENABLE_XXX options to NETCDF_ENABLE_XXX options
  CI: Create an MSYS2/MinGW CMake run.
  CI: Test on MSYS2/UCRT64 environment
  CMake: Fix running tests on MinGW
@WardF WardF self-assigned this May 15, 2024
@WardF
Copy link
Member

WardF commented May 15, 2024

@DennisHeimbigner anything leap out at you about this PR? Now that tests are passing, I'm doing a full review but will hold off on merging, to give you time to weigh in.

@WardF WardF merged commit 5d70252 into Unidata:main May 16, 2024
106 checks passed
@ZedThree ZedThree deleted the silence-ncdap4-warnings branch May 16, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WardF WardF WardF approved these changes

@DennisHeimbigner DennisHeimbigner DennisHeimbigner approved these changes

Assignees

@WardF WardF

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZedThree @WardF @DennisHeimbigner