Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New PCT uptake functions #89

Open
4 of 5 tasks
Robinlovelace opened this issue Oct 29, 2024 · 1 comment · Fixed by #90
Open
4 of 5 tasks

New PCT uptake functions #89

Robinlovelace opened this issue Oct 29, 2024 · 1 comment · Fixed by #90

Comments

@Robinlovelace
Copy link
Collaborator

Robinlovelace commented Oct 29, 2024 •
edited
Loading

There are in fact many PCT uptake functions, in the pct R package.
I think we should have the following ones implemented:

The "2" signifies more recent versions after we recalibrated the model. Basically, I think we should add those 3 additional functions.

I'm up for giving it a first bash, needed for SchoolRoutes
@Robinlovelace Robinlovelace linked a pull request Oct 29, 2024 that will close this issue
Update PCT functions, close #89 #90
Merged
Robinlovelace added a commit that referenced this issue Oct 29, 2024
@Robinlovelace
Merge pull request #90 from Urban-Analytics-Technology-Platform/89-ne…
83a1b6d 
…w-pct-uptake-functions

Update PCT functions, close #89
@Robinlovelace
Copy link
Collaborator Author

Just one more to go (the e-bike one) and may be worth doing some more spot checks compared with R versions so re-opening. See R spot checks in link below..

Robinlovelace added a commit to acteng/netgen that referenced this issue Oct 29, 2024
@Robinlovelace
Add spot checks, see Urban-Analytics-Technology-Platform/od2net#89 fo…
e8040ae 
…r reference
@Robinlovelace Robinlovelace reopened this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update PCT functions, close #89 Urban-Analytics-Technology-Platform/od2net
1 participant
@Robinlovelace