Update PCT functions, close #89

[Robinlovelace]

No description provided.

[dabreegster]

I pushed a commit to wire this up. In the config json, they're called GovTargetSchool and GoDutchSchool

[Robinlovelace]

Perfect, quite easy to extend. Will try to add some tests before merging.

[dabreegster]

Sure, tests would be good. You could follow the example of

od2net/od2net/src/plugins/uptake.rs

Line 98 in f333f43

#[test]

and just dump output to a CSV file and do something to manually compare. Or if you want to assert a few input values produce the expectd output, that's easy too

[Robinlovelace]

See the simpler spot checks I've done. What's the chance of the spot checks passing but the function being wrong? Close to 0.

[Robinlovelace]

Good to merge? First Rust code I've written in a while and pretty happy if so!

[Robinlovelace]

Tests passing locally:

cargo test
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.14s
     Running unittests src/lib.rs (target/debug/deps/lts-6c66a489189eafb7)

running 1 test
test tests::test_bike_ottawa ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/debug/deps/od2net-c465a29c5326b2f8)

running 3 tests
test network::tests::speed_slope_test ... ok
test plugins::uptake::tests::test_school ... ok
test plugins::uptake::tests::test_pct ... ok

test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

     Running unittests src/main.rs (target/debug/deps/od2net-44ec9ba0516d0294)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/debug/deps/wasm_od2net-692a233dc88a845d)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests lts

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests od2net

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests wasm_od2net

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

[Robinlovelace]

Note: I only understand the checks for the school uptake functions but can do spot checks for the other ones at some point also.