Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in tensor hash test case #179

Closed
Krzmbrzl opened this issue Feb 6, 2024 · 1 comment · Fixed by #180
Closed

Bug in tensor hash test case #179

Krzmbrzl opened this issue Feb 6, 2024 · 1 comment · Fixed by #180

Comments

@Krzmbrzl
Copy link
Collaborator

Krzmbrzl commented Feb 6, 2024

SeQuant/tests/unit/test_tensor.cpp

Line 100 in 42558e9

REQUIRE_NOTHROW(t1_hash != t2_hash);

This only checks that the comparison doesn't throw and disregards the result of the comparison. I assume this is not the desired behavior? 👀
@evaleev
Copy link
Member

evaleev commented Feb 6, 2024

Oh, definitely ... good catch ...

Krzmbrzl added a commit to Krzmbrzl/SeQuant that referenced this issue Feb 6, 2024
@Krzmbrzl
Fix test case not actually doing any testing
70aaf27 
Fixes ValeevGroup#179
@Krzmbrzl Krzmbrzl mentioned this issue Feb 6, 2024
Merged
evaleev pushed a commit to Krzmbrzl/SeQuant that referenced this issue Feb 14, 2024
@Krzmbrzl @evaleev
Fix test case not actually doing any testing
5d7becd 
Fixes ValeevGroup#179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix hash_value template resolution Krzmbrzl/SeQuant
2 participants
@evaleev @Krzmbrzl