Fix hash_value template resolution #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krzmbrzl
changed the title
Krzmbrzl
commented
Feb 8, 2024
| seed = begin->hash_value(); | ||
| else { | ||
| using sequant_boost::hash_value; | ||
| [[maybe_unused]] std::size_t seed = hash_value(*begin); |
There was a problem hiding this comment.
There is a functional change here where previously the hash-value of *begin would be computed, but the result would be discarded and the original seed would be left in an uninitialized state. This seemed like a bug to me, so I changed it but you'll probably want to double-check that this was not intended behavior after all 👀
There was a problem hiding this comment.
indeed, late night coding, ignored what the compiler was trying to tell me ... 5ff476d
By bringing the Boost hash_value functions into the SeQuant namespace, some instantiations of the hash_value function resolved to the general Boost functions instead of using the specializations provided by SeQuant. In particular, expression objects with a hash_value member function would simply be hashed via a generic hash_range implementation (as every expression is also a range) instead of using the template specialization that delegates to the (memoizing) hash member function. This issue is resolved by not importing the functions from the Boost namespace but instead keeping two specializations in the SeQuant namespace that either resolve to the member function (if present) or the generic Boost function (if the object does not have a hash member function and a suitable overload on Boost's side is found).
evaleev
force-pushed
the
fix-tensor-hashing
branch
from
135d363 to
9f87160
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #179