Skip to content

Commit

Permalink
Remove irrelevant comments from metric name field (open-telemetry#512)
Browse files Browse the repository at this point in the history
  • Loading branch information
tigrannajaryan authored and VinozzZ committed Jun 21, 2024
1 parent 8b022d8 commit 458784b
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions opentelemetry/proto/metrics/v1/metrics.proto
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,9 @@ message ScopeMetrics {
// when the start time is truly unknown, setting StartTimeUnixNano is
// strongly encouraged.
message Metric {
// name of the metric, including its DNS name prefix. It must be unique.
reserved 4, 6, 8;

// name of the metric.
string name = 1;

// description of the metric, which can be used in documentation.
Expand Down Expand Up @@ -536,7 +538,7 @@ message ExponentialHistogramDataPoint {
// doing so. This is specifically to enforce compatibility w/ OpenMetrics,
// see: https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#histogram
optional double sum = 5;

// scale describes the resolution of the histogram. Boundaries are
// located at powers of the base, where:
//
Expand Down Expand Up @@ -574,7 +576,7 @@ message ExponentialHistogramDataPoint {
// of counts.
message Buckets {
// Offset is the bucket index of the first entry in the bucket_counts array.
//
//
// Note: This uses a varint encoding as a simple form of compression.
sint32 offset = 1;

Expand All @@ -588,7 +590,7 @@ message ExponentialHistogramDataPoint {
// especially zeros, so uint64 has been selected to ensure
// varint encoding.
repeated uint64 bucket_counts = 2;
}
}

// Flags that apply to this specific data point. See DataPointFlags
// for the available flags and their meaning.
Expand Down

0 comments on commit 458784b

Please sign in to comment.