Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove irrelevant comments from metric name field #512

Conversation

tigrannajaryan
Copy link
Member

The comment was incorrect and misleading.

Fixes #511

The comment was incorrect and misleading.

Fixes open-telemetry#511
@tigrannajaryan tigrannajaryan requested review from a team November 1, 2023 16:49
@arminru arminru merged commit f674adf into open-telemetry:main Nov 7, 2023
15 checks passed
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify meaning of *DNS name prefix* in protobuf code comment for metric name
7 participants