Show basic wind points on the map #1373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m:WFP-VAM/prism-app into feat/handle-multiple-AA-layers-and-panels
Max-Z80
changed the title
Max-Z80
force-pushed
the
feat/show-wind-points-on-map
branch
from
4a73e77 to
c3f8ce2
Compare
Max-Z80
force-pushed
the
feat/show-wind-points-on-map
branch
from
c3f8ce2 to
4732586
Compare
Base automatically changed from
feat/handle-multiple-AA-layers-and-panels
to
feature/add-new-AA-storm
December 2, 2024 15:26
Max-Z80
force-pushed
the
feat/show-wind-points-on-map
branch
from
4732586 to
5700119
Compare
ericboucher
reviewed
Dec 4, 2024
frontend/public/images/anticipatory-action-storm/very-intensive-tropical-cycloone.png
Outdated
Show resolved
Hide resolved
ericboucher
reviewed
Dec 4, 2024
frontend/src/components/MapView/Layers/AnticipatoryActionStormLayer/AAStormDatePopup/index.tsx
Outdated
Show resolved
Hide resolved
|
Great start. I would recommend adding a few more comments throughout the code to explicit some of the business logic |
|
Build succeeded and deployed at https://prism-1373.surge.sh |
…AM/prism-app into feat/show-wind-points-on-map-2
- fix date formating - relocalize feature types to a dedicated file - use useMapCallback instead of the mapRef
…-VAM/prism-app into feat/show-wind-points-on-map
add lines between wind points --------- Co-authored-by: Maxime Chaillet <[email protected]>
…AM/prism-app into feat/show-wind-points-on-map-2
ericboucher
reviewed
Dec 9, 2024
| @@ -0,0 +1,40 @@ | |||
| import { isSameDay, parseJSON, format, addHours } from 'date-fns'; | |||
There was a problem hiding this comment.
Let's wait a bit but I don't think we need all these functions
All times will eventually be in UTC as Amine mentioned so we can simply use the existing getTimeInMilliseconds and then update the getFormattedDate in date-utils
ericboucher
reviewed
Dec 9, 2024
| component: ComponentType<{ layer: DiscriminateUnion<U, 'type', T> }>; | ||
| component: ComponentType<{ | ||
| layer: DiscriminateUnion<U, 'type', T>; | ||
| mapRef: MapRef; |
ericboucher
changed the title
|
Merged via #1401 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show wind points on the map
How to test the feature:
Checklist - did you ...
Test your changes with
REACT_APP_COUNTRY=rbd yarn startREACT_APP_COUNTRY=cambodia yarn startREACT_APP_COUNTRY=mozambique yarn startScreenshot/video of feature: