Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load available dates and storm from dates endpoint #1401

Merged
merged 160 commits into from
Jan 8, 2025
Merged

Load available dates and storm from dates endpoint #1401

merged 160 commits into from
Jan 8, 2025

Conversation

ericboucher
Copy link
Collaborator

@ericboucher ericboucher commented Dec 20, 2024 •
edited
Loading

Description

  • Load available dates from /dates directly instead of using /latest
  • Make sure click and date selections propagate throughout the app
  • Rely on the forecastDetails instead of the selectedDateTime
  • Fix closing tooltip that was preventing click on different hours

How to test the feature:

  • [ ]
  • [ ]

Checklist - did you ...

Test your changes with

  • REACT_APP_COUNTRY=rbd yarn start
  • REACT_APP_COUNTRY=cambodia yarn start
  • REACT_APP_COUNTRY=mozambique yarn start
  • Add / update necessary tests?
  • Add / update outdated documentation?

Screenshot/video of feature:

Doniaab and others added 30 commits November 22, 2024 19:17
@Doniaab
Divided AA into drought and storm layers and panels
3e1a407
@Doniaab
fix misspelling and try to fix url update AA selection change
f53ba7e
@Doniaab
updated switch AA layers in url
972708d
@ericboucher
Fix tests
928930a
@Doniaab
reset start date on switch AA action
8d23445
@Doniaab
Merge branch 'feat/handle-multiple-AA-layers-and-panels' of github.co…
32e918c 
…m:WFP-VAM/prism-app into feat/handle-multiple-AA-layers-and-panels
do not show data in the timeline when layer anticipatory_action_storm…
06c9768 
… is selected
isolate AA drought specific legen items, setup empty legend for AA storm
6489a7d
clean AAstormPanel
352eace
move AA drought specific components to AADroughtPanel folder
26dc723
do not show elements on the map for storm AA
22a807a
fix linting issues
6cbb858
fix tests
0e3edce
enable the display of 2 aa layers only for aa_drought
f0eccc0
add json data in a temporary file
4c7b9f9
show basic wind points on the map
6619135
use data from json file; add tooltip containing day
5700119
show exposed wind area
dc8ddc0
create tooltip for landfall
ccd3c4b
use a single layer to display wind points
8cf1f93
toogle display of the landfall popup
90afd3c
@ericboucher
Update cursor to pointer over wind points
1d2f2a7
@ericboucher
Stop default propagation
fcc088a
@ericboucher
Merge branch 'feature/add-new-AA-storm' into feat/show-wind-points-on…
79b11ab 
…-map
@ericboucher
Fix linter and tests
23562ef
@ericboucher
Merge branch 'feat/show-wind-points-on-map' of https://github.com/WFP…
42302be 
…-VAM/prism-app into feat/show-wind-points-on-map
@ericboucher
Update index.tsx
7be0a43
@ericboucher
fix typo in cyclone file name
ccf0799
isolate landfall popup content to be able to test it
116f28f
Merge branch 'feat/show-wind-points-on-map' of ssh://github.com/WFP-V…
1df976d 
…AM/prism-app into feat/show-wind-points-on-map-2
@ericboucher ericboucher marked this pull request as ready for review December 22, 2024 22:58
ericboucher and others added 4 commits January 7, 2025 11:39
@ericboucher
Use lines instead of polygon fills
caf6e56
@ericboucher
Default to January start for timeline AA Storm
9f04dea
@ericboucher
Replace buffer by uncertainty cone
1726c44
@wadhwamatic
add icons
1b4b5ba 
add disturbance and replace low pressure with with disturbance as these match the iconography seen in meteo france storms https://meteofrance.re/fr/cyclone
@ericboucher ericboucher changed the base branch from feat/timeline-tooltip to feature/add-new-AA-storm January 8, 2025 21:16
@ericboucher ericboucher merged commit f3fa82b into feature/add-new-AA-storm Jan 8, 2025
6 checks passed
@ericboucher ericboucher deleted the load-from-dates branch January 8, 2025 21:18
This was referenced Jan 8, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Max-Z80 Max-Z80 Awaiting requested review from Max-Z80

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericboucher @Doniaab @wadhwamatic