Fix loading AA layers #1392
Merged
Fix loading AA layers #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to fetch-data-in-state
…m-app into fetch-data-in-state
Doniaab
changed the base branch from
feat/display-panel-AA-storm
to
fetch-data-in-state
|
Build succeeded and deployed at https://prism-1392.surge.sh |
ericboucher
reviewed
Dec 12, 2024
| @@ -72,12 +72,29 @@ const TabPanel = memo(({ children, value, index, ...other }: TabPanelProps) => ( | |||
| const LeftPanel = memo(() => { | |||
| const dispatch = useDispatch(); | |||
| const tabValue = useSelector(leftPanelTabValueSelector); | |||
|
|
|||
| const selectedLayers = useSelector(layersSelector); | |||
There was a problem hiding this comment.
A lot of the changes look like positioning. Can we just make the necessary changes for the fix to make it easier to review? :)
There was a problem hiding this comment.
the thing is that AAConfig needed AALayerInUrl instead of tabValue ( that was the main change for the fix). So i had to define AALayerInUrl before AAConfig and SelectedLayers before AALayerInUrl.
Base automatically changed from
fetch-data-in-state
to
feat/display-panel-AA-storm
December 13, 2024 12:26
|
I opened #1393 as a follow up |
ericboucher
added a commit
that referenced
this pull request
Jan 8, 2025
Co-authored-by: Maxime Chaillet <[email protected]> Co-authored-by: ericboucher <[email protected]> Co-authored-by: Amit W <[email protected]> Co-authored-by: donia benharara <[email protected]> Co-authored-by: Doniaab <[email protected]> Fix loading AA layers (#1392)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #issueNumber.
How to test the feature:
Checklist - did you ...
Test your changes with
REACT_APP_COUNTRY=rbd yarn startREACT_APP_COUNTRY=cambodia yarn startREACT_APP_COUNTRY=mozambique yarn startScreenshot/video of feature: