Codeception acceptance tests fail randomly

[JDGrimes]

While doing local testing, I've found that the tests will fail randomly. This will often occur the first 1-2 times that a test is run, then after that it will work correctly. After a few minutes the whole thing often ensues all over again. The failures always happen at the step after the login step, and it turns out that it is the login step itself that is failing.

I haven't yet tried to debug why this is happening, and perhaps it is related to my local set-up and isn't a global issue (I can't remember for sure whether I've observed failures matching this pattern on Travis CI or not).

One really strange aspect of it is that when a failure like this occurs, the failing test usually takes 2-3 times as long to complete as when it would succeed/fail for another reason. It makes me wonder if we have a race condition, and it only manifests itself when the underlying site is loading too slowly, or something.

[JDGrimes]

Yep, this is happening on Travis.

[JDGrimes]

This does still happen, and happens on Travis sometimes still as well. However, it currently isn't egregious enough that I'm going to tackle it before this release. We'll get to it eventually though.

[JDGrimes]

lucatume/wp-browser#65 might be a fix for this issue. It hasn't been causing us much headache on Travis recently though.

[JDGrimes]

I just enabled an xDebug breakpoint on this error to see what is causing it, and the username submitted was shown to be dmin rather than admin. So apparently the issue is that the form fields are being filled out before they are actually ready. That ticket upstream might indeed fix the issue in that case.

[JDGrimes]

Applying a fix similar to in that issue did not seem to help. I tried filling the field twice instead, and that seems to have worked; so far I haven't experienced these random failures anymore.

[JDGrimes]

Calling this fixed, if we continue to see issues we can reopen.