WPWebDriver: Wait for login form elements

[tangrufus]

WPWebDriver::loginAs and WPWebDriver::loginAsAdmin should wait for form elements before submission. This explicit_wait prevents race conditions.

[calvinalkan]

This costed me way too much time.

But I'm now 99% sure the issue happens because of this JS that WP runs on the login page.

function wp_attempt_focus() {setTimeout( function() {try {d = document.getElementById( "user_login" );d.focus(); d.select();} catch( er ) {}}, 200);}
wp_attempt_focus();
if ( typeof wpOnload === 'function' ) { wpOnload() }		

WP tries to auto-select the user login field which totally messes up how codeception fills out forms.

Current solution with the login cookies and retries is actually not the correct way to solve this.

[calvinalkan]

This is what should be used:

$this->tester->waitForJS('return document.activeElement == document.getElementById("user_login")');

[calvinalkan]

Also, include cases where PW is incorrect:

$this->tester->waitForJS("return (document.activeElement === document.getElementById('user_login')) || (document.activeElement === document.getElementById('user_pass'))");

[lucatume]

Thanks @calvinalkan for coming back to the issue and providing this.
I will review and include this new code in the next version of wp-browser (v4) based on Codeception v5.

This JS-based approach will work for the WPWebDriver module as the WPBrowser module does not have JS support hence not the same problem.