Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery: choosing thumbnail size #1450

Closed
mtias opened this issue Jun 26, 2017 · 35 comments · Fixed by #18581
Closed

Gallery: choosing thumbnail size #1450

mtias opened this issue Jun 26, 2017 · 35 comments · Fixed by #18581
Assignees
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement. [Type] Question Questions about the design or development of the editor.
Milestone

Comments

@mtias
Copy link
Member

mtias commented Jun 26, 2017

This is not a great experience in core at the moment, but since some themes / people may be relying on specific thumbnail generation for galleries, it'd be good to offer that option in the inspector, to choose a specific thumbnail size from the registered ones.

@mtias mtias added [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement. [Type] Question Questions about the design or development of the editor. labels Jun 26, 2017
@paulwilde
Copy link
Contributor

A consideration is that these options can currently be filtered in core with the image_size_names_choose filter.

@kopepasah
Copy link
Member

@mtias by "thumbnail size" I assume you referring to a registered image size. If that is the case this might be an issue because the registered image size may not have an image size stored in the upload directory, as adding an image size does not resize the currently uploaded images.

@kopepasah
Copy link
Member

I see @mkaz and @jasmussen are assigned this issue (as of this comment). Are either of you currently working on this implementation?

@jasmussen
Copy link
Contributor

Are either of you currently working on this implementation?

I'm not, and I don't think Marcus has started yet either. We have a few other tickets to look at also, https://github.com/WordPress/gutenberg/issues/assigned/mkaz so please feel free to take this one if you're feeling adventurous, would really apprecaite it. Worst case, you can push your work early, and ping us, and we can work together.

💓

@mkaz
Copy link
Member

mkaz commented Jun 29, 2017

Correct, I'm still working on #1444 #1445 and #1447 which all involve gallery & media modal - so haven't started on this one yet

@jasmussen jasmussen assigned kopepasah and unassigned mkaz and jasmussen Jun 29, 2017
@jasmussen
Copy link
Contributor

Reassigned this one to you, @kopepasah, but if it drops off your radar for any reason (understandable), just ping us and we'll be back on!

@mtias mtias added the [Feature] Media Anything that impacts the experience of managing media label Jun 29, 2017
@karmatosed karmatosed added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Aug 3, 2017
@Axinet
Copy link

Axinet commented Oct 13, 2017

If "image block" has a combo box to choose from registered image sized I don't understand the hesitation to provide a similar mechanism for the gallery block. In both cases there is a possibility that user may not have an image size stored in the upload directory, but looking at popularity of "Regenerate Thumbnails" plugin people are aware how to deal with it (by the way it is strange that core allow changing image sizes assigned to medium and large names but has no option to handle already uploaded files).

@jeffpaul
Copy link
Member

This ticket was mentioned in Slack in #core-editor by jeffpaul. View the logs.

@fabianpimminger
Copy link
Contributor

Would be great if there is a solution to this (even as an intermediary step until there is better image size support/foundation in core as mentioned in the slack channel)

Think of all users that are uploading images in full sizes. This quickly adds big amounts of traffic to a site.

@klihelp
Copy link

klihelp commented Mar 8, 2018

+1

@radogado
Copy link

radogado commented Mar 9, 2018

Inserting huge full size images would break the page. Thumbnails also needed for Lightbox modules.

@markfinst
Copy link

Please store image attachment IDs in JSON comment blocks (<!-- wp:gallery --> and <!-- wp:image -->). So content can be easily filtered by backend code.

In the current version of Gutenberg only wp:image stores attachment ID, wp:gallery - doesn't.

If this won't happen, every plugin or theme that wants to modify Gutenberg gallery HTML markup needs to create another block. Which breaks backward's compability.

More info at: #8193

@antpb
Copy link
Contributor

antpb commented Oct 28, 2018

I think @markfinst 's recommendation is a good one. (storing ids.) There are a few instances I could see this being useful:

  1. Gallery shortcode fallbacks to respect older filters will likely rely on ids ( Gallery: figure out way to fallback to shortcode #1451)
  2. Reduce Requests for the gallery block #10994 - though this issue may be a little more complicated than just getting all the ids to a single REST request, having ids stored will help make that an option.
  3. extendability
  4. transform possibilities

For #1451 I am exploring a classic-gallery block that allows for inspector controls in the sidebar. A temporary solution to this issue would be transforming large galleries to a shortcode or classic-gallery block. If we had the ids stored, this would be easy to adjust to. @mtias, I wanted to bring this one to your attention as we continue to discuss the possibility of a classic-gallery block.

screen shot 2018-10-28 at 3 33 33 pm

Here's the branch where I am building the classic-gallery block: https://github.com/antpb/gutenberg/tree/add/classic-gallery

@mtias
Copy link
Member Author

mtias commented Nov 14, 2018

We are consolidating image handling improvements in #6177. This is a good opportunity to avoid offloading the responsibility of determining the right size (performance, weight, quality) to the user and the engine doing it instead with responsiveness in mind.

Moving this out of 5.0 as there could still be some additions to the gallery block around showing certain cropped thumbnails as options, but it needs a better presentation as well.

@StancuFlorin
Copy link

Is this still on the roadmap?

@anybodesign
Copy link

Hi there :)

Is it still planned to add the possibility to choose the thumbnail size in the gallery block? (As well as the "Link to" feature)

It is a heavily needed feature, there's a real performance issue with large galleries (20 and more picture). So far it is also impossible to create a gallery with square thumbnails.

Hope to hear from you soon

@u451f
Copy link

u451f commented Mar 12, 2019

I'm also still looking for a fix or at least a workaround for this issue: either provide a general setting what image size galleries should link to or a per-gallery setting as it was pre-Gutenberg. Any hints?

@maffi-git
Copy link

maffi-git commented Mar 21, 2019

Workaround for now seems to install the classic editor or use a gallery plugin. I've just started to implement a new site for a customer and this was the first real issue. Not beeing able to choose the thumbnail breaks the thing for me.
Croping for the same size would be a partial-solution - I will try to find a styledefinition for that - croping for the same height looks not nice in my test-case.

Defining a fixed height for the class .blocks-gallery-item seems to do the trick. In my case:
.blocks-gallery-item {
height: 150px;
}
Created a consistent look with the old galeries.

@Backpackstudio
Copy link

To be honest, it's a disaster to not have an option to choose thumbnail size for gallery.

@drewclifton
Copy link

Any updates on this? As I run into this issue and reflect on its ramifications, I'm actually surprised the gallery block was even released in this state. Thank you!!! 😃

@patbar5
Copy link

patbar5 commented Jul 12, 2019

Ref the tip :
Defining a fixed height for the class .blocks-gallery-item seems to do the trick. In my case:
.blocks-gallery-item {
height: 150px;
}

Any tips how to handle the image width ? I tried the below...not working on mobile/cell phones
.blocks-gallery-item {
height: 150px;
width: 150px;
}

@simboonlong
Copy link

simboonlong commented Nov 6, 2019

+1

@TheAggressive
Copy link

TheAggressive commented Nov 17, 2019

2 years later and this is still not fixed? Why are we sending large images over cellular networks? Wouldn't be better to load thumbnail images rather than large size that would have to be converted with CSS to appear as thumbnails? WordPress prides itself on being backwards compatible but this compatibility is broke in this block component. I would strongly consider fixing issues before continuing on new features. Priority should be HIGH

@mmtr mmtr assigned mmtr and unassigned kopepasah Nov 18, 2019
Tug pushed a commit that referenced this issue Feb 28, 2020
@frogdesk
Copy link

Adding the images size selector didn't fix this problem. The gallery should use one size for the thumbnails and a different size for the full size. That is the problem to begin with. This should have been a release blocker.

@natedolesh
Copy link

Agreed that this still seems to be an issue in 2021. I try to select Thumbnail from the dropdown, but it just goes back to Large.
After so many iterations, we don't have a functional gallery block?

@umviajante
Copy link

same problem around here and I still haven't figured out a solution ...

@frogdesk
Copy link

same problem around here and I still haven't figured out a solution ...

Unfortunately that is because there is no solution, evidently the Gutenberg developers see the gallery block as a developer example and not as an actually usable production level block. It is most unfortunate that this block is even included in general WordPress releases because it is clearly not intended for production use.

@skorasaurus
Copy link
Member

skorasaurus commented Mar 10, 2021

@frogdesk & @umviajante @natedolesh

I agree that the larger images are still being loaded; is really frustrating.
I was curious myself about the status of it so I wrote this recap a couple weeks ago that summarizes the issues around loading larger than necessary images in Gutenberg.

There's not quite one 'issue' at the moment that developers are uniting around (and this issue spans multiple issues.
So to keep track of the progress around it but #20778 may be helpful.

@radogado
Copy link

It is unsustainable to insert 100 images at full size and the app will break. We need the old style gallery with thumbnails. Maybe stability should be top priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement. [Type] Question Questions about the design or development of the editor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.