Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Add video example to the block library #17655

Closed
jasmussen opened this issue Sep 30, 2019 · 0 comments · Fixed by #20703
Closed

Enhancement: Add video example to the block library #17655

jasmussen opened this issue Sep 30, 2019 · 0 comments · Fixed by #20703
Assignees
@mtias
Labels
[Package] Block library /packages/block-library [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jasmussen
Copy link
Contributor

In #17493, we area adding block examples to most blocks.

Whereas all the images are stored on a nonprofit Wikimedia server with an explicitly permissing hotlinking policy, the video needs to be on a CDN, ideally a WordPress.org CDN.

This takes a little bit and in the name of shipping improvements to the other blocks, we're extracting that one out. So when there's time, let's add back this:

65885530-21527980-e39b-11e9-9006-495364ce4bac

Here's the video:

https://make.wordpress.org/design/files/2019/03/block-manager.mp4
@jasmussen jasmussen added [Type] Enhancement A suggestion for improvement. [Package] Block library /packages/block-library labels Sep 30, 2019
jasmussen added a commit that referenced this issue Sep 30, 2019
@jasmussen
Remove the video for now.
a57bac8 
I have created #17655 to add it back.
@mtias mtias mentioned this issue Mar 8, 2020
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtias mtias

Labels
[Package] Block library /packages/block-library [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add example preview to video block. WordPress/gutenberg
2 participants
@mtias @jasmussen