Add example preview to video block. #20703
Conversation
mtias
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
|
Size Change: +147 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
|
cc @jasmussen |
|
Internet Explorer 11 doesn't support the webm format, see caniuse. Maybe we should use a MP4 file. |
|
This video is so lovely. But there are some challenges with it. Hotlinking files on Wikimedia are explicitly fine, and I would suggest that hover previews not working in IE11 is not a blocker because it's not accessibility related, and it's fundamentally necessary for the editor to work. However the video is CC licensed 😩 https://commons.wikimedia.org/wiki/File:Wood_thrush_in_Central_Park_switch_sides_(16510).webm While we could use it with attribution, in the past we've avoided that because of the challenge of where do we show that attribution. This one is public domain, though: https://commons.wikimedia.org/wiki/File:Wood_thrush_(Hylocichla_mustelina).webm — it's not as good a video, but perhaps it serves the same purpose? |
|
We are just linking to it, not embedding though. We could also just use a poster image since it doesn't seem to autoplay anyways. |
|
Should we land it? |
|
Yes, I think so |
|
I'll rebase and merge 😄 |
gziolo
force-pushed
the
add/video-example
branch
from
e2e4f50 to
4e33422
Compare
|
I rebased and updated the example to include the caption, this is how it works on Safari:
I think Let's decide what we do about this PR given the issues the video creates on the browser support level and in terms of licensing as pointed out by @jasmussen. |
|
It's just a link to a wikimedia resource |
Closes #17655