Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Block - create from existing Menus #18575

Closed
getdave opened this issue Nov 18, 2019 · 8 comments · Fixed by #18869
Closed

Nav Block - create from existing Menus #18575

getdave opened this issue Nov 18, 2019 · 8 comments · Fixed by #18869
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress

Comments

@getdave
Copy link
Contributor

getdave commented Nov 18, 2019

68409486-256d7600-0155-11ea-8414-0243bee06aef

In the original Issue around the initial state for the placeholder for the Nav Block we discussed having the ability to create a Nav from an existing WP Menu.

We can't do this because of the lack of a REST API endpoint. There is also an Issue for that.

Once that Issue is resolved we should look to add this functionality to the Block.

Describe the solution you'd like
Ability to select from an existing WP Menu and have a Nav created from that.

@getdave getdave added [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Block] Navigation Affects the Navigation Block labels Nov 18, 2019
@getdave
Copy link
Contributor Author

getdave commented Nov 18, 2019

Highly relevant comment on getting the API endpoint launched

#18373 (comment)

@retrofox
Copy link
Contributor

retrofox commented Dec 9, 2019

I've been working as well in an approach to this issue. Let me paste the very draft PR

@getdave
Copy link
Contributor Author

getdave commented Jan 9, 2020

I'm going to take this up again now.

@getdave
Copy link
Contributor Author

getdave commented Jan 9, 2020

@shaunandrews Pinging you because you were involved in the original implementation. If you've had any further thoughts on the design implementation of this please do let us know. We're working on the technical implementation now so would be good to have the design to implement alongside it also. Much appreciated.

cc @karmatosed.

@shaunandrews
Copy link
Contributor

Here's a quick mockup of how we could adapt the initial setup state to allow for choosing existing menus:

image

@karmatosed
Copy link
Member

I think this simple adaption of the 'create empty' to be a drop down works @shaunandrews. My only ponder is about making 'new' say 'create' and maybe be at the top.

@paaljoachim
Copy link
Contributor

paaljoachim commented Feb 7, 2020

How is this feature coming along?
If the Nav Block is shipped with WordPress 5.4. This will be one missing feature that I believe will often come up in the support forum as well as other places. Answering with that one can not add an pre-existing menu at this time to the Nav block does not look good. If it is possible to add to the feature while in beta then that is great. Throwing a likely solution quickly together before sometime Monday so one can use a month during beta to improve it could also be a solution (not a great solution but one solution to get it in).

@getdave

@spacedmonkey
Copy link
Member

I have created a PR for the menus endpoints - #20292 based on the feature plugin https://github.com/WP-API/menus-endpoints

getdave added a commit that referenced this issue Apr 17, 2020
Adds placeholder options and allows creation of empty from Menu dropdown. Aligns all items in a horizontal layout.

See #18575 (comment)
getdave added a commit that referenced this issue Apr 22, 2020
Adds placeholder options and allows creation of empty from Menu dropdown. Aligns all items in a horizontal layout.

See #18575 (comment)
@talldan talldan removed the [Feature] List View Menu item in the top toolbar to select blocks from a list of links. label Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants