-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add menus endpoints. #20292
Add menus endpoints. #20292
Conversation
CC // @marekhrabe @draganescu |
@spacedmonkey this is awesome news for the Navigation block :) Is there a Trac ticket we could tie this PR to? |
@draganescu The original ticket is https://core.trac.wordpress.org/ticket/40878 This PR has a lot of code in, but barring some very small tweaks ( to change the name from |
My bad @spacedmonkey :) I didn't pay attention to which repo this is and I thought it was a patch for core (a PR against the wordpress-develop master) 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have worked with this PR in #18869 and have had no issues. Also considering:
- all endpoints are 'hidden' behind
__experiemental
, - the code comes straight from the feature plugin where it has been reviewed extensively by the REST API team
we can merge this and use it for the issues that need it.
I'm really pleased to see this got merged 🎉 🎉 🎉 Great work everyone. |
Description
Add menu endpoints from https://github.com/WP-API/menus-endpoints
How has this been tested?
Screenshots
Types of changes
Checklist: