Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Editor: Add README for FontFamilyControl component #52118

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Block Editor: Add README for FontFamilyControl component #52118

merged 2 commits into from
Jun 30, 2023

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Jun 29, 2023

What?

This PR adds a README for the FontFamilyControl component.

Fixes #52052.

Why?

Part of #22891 where we aim to document all block editor components.

How?

Just adding a README.

Testing Instructions

Not needed.

Testing Instructions for Keyboard

None.

Screenshots or screencast

None.

@tyxla tyxla added [Type] Developer Documentation Documentation for developers [Package] Block editor /packages/block-editor labels Jun 29, 2023
@tyxla tyxla self-assigned this Jun 29, 2023
@tyxla tyxla requested a review from ellatrix as a code owner June 29, 2023 12:02
@tyxla tyxla mentioned this pull request Jun 29, 2023
Closed
mburridge
mburridge approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@mburridge mburridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A screenshot illustrating the control would be a nice touch, as other readme's have, but this is great. Thank you, and thanks for your quick response.

@tyxla
Copy link
Member Author

tyxla commented Jun 30, 2023

LGTM. A screenshot illustrating the control would be a nice touch, as other readme's have, but this is great. Thank you, and thanks for your quick response.

Thanks, screenshot was added in e7c2ee2.

@tyxla tyxla enabled auto-merge (squash) June 30, 2023 10:49
@tyxla tyxla disabled auto-merge June 30, 2023 12:21
@tyxla tyxla merged commit 099ea67 into trunk Jun 30, 2023
@tyxla tyxla deleted the add/font-family-component-readme branch June 30, 2023 12:21
@github-actions github-actions bot added this to the Gutenberg 16.2 milestone Jun 30, 2023
@mburridge mburridge mentioned this pull request Jun 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mburridge mburridge mburridge approved these changes

@youknowriad youknowriad Awaiting requested review from youknowriad

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

Assignees

@tyxla tyxla

Labels
[Package] Block editor /packages/block-editor [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 16.2
Development

Successfully merging this pull request may close these issues.

Add README.md file for font-family component
2 participants
@tyxla @mburridge