Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try attached container for the block movers. #17234

Closed
wants to merge 2 commits into from

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Aug 28, 2019

Alternate to #17216. As proposed in #16580 (comment).

Still a little buggy, but this is a rough first implementation of adding an attached block container around the block movers:

Screen Shot 2019-08-28 at 9 28 38 AM

  • Needs revised focus states
  • Needs to be revised so that it works on short blocks (like one-line paragraphs)
  • Needs to include a treatment for wide/full blocks

@kjellr kjellr added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. labels Aug 28, 2019
@kjellr kjellr self-assigned this Aug 28, 2019
@shaunandrews
Copy link
Contributor

I strongly prefer the pill shape you have in #17216 — this squared version feels too “blocky” (heh) and blends in with the block toolbar. Having the controls attached also leads to the block feeling very heavy when focused.

@kjellr
Copy link
Contributor Author

kjellr commented Sep 3, 2019

Closing this one now that #17216 has been merged.

@kjellr kjellr closed this Sep 3, 2019
@kjellr kjellr deleted the try/block-mover-attached branch September 3, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants