Template Switcher: Add current theme #21578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.17 kB (0%) Total Size: 841 kB
ℹ️ View Unchanged
|
ockham
changed the title
ockham
force-pushed
the
add/current-theme-to-template-switcher
branch
from
3704d06 to
4950572
Compare
|
I wonder, does the code in #222 need to go into the Gutenberg plugin for the time being? Otherwise, wouldn't the feature be broken until the next WordPress core update? |
I think so, yeah. Probably by tapping into |
Yep, that worked: c74cf62 🎉 |
ockham
requested review from
ajitbohra,
chrisvanpatten,
mkaz,
nerrad,
TimothyBJacobs and
youknowriad
as code owners
youknowriad
approved these changes
Apr 17, 2020
Thanks Riad! Ah, looks like it's actually a PHP unit test, I'll look into it. Edit: Nope, PHP lint run inside Travis' unit test job 😅 |
53 tasks
12 tasks
6 tasks
ockham
added a commit
that referenced
this pull request
Jun 28, 2020
In #21578, I added a few fields to Core's `/themes` endpoint, for use by the Site Editor's Template Switcher (see both #21578 and #21768). I then submitted those changes as a [PR](WordPress/wordpress-develop#222) against Core. That PR underwent a number of modifications and was eventually merged; the new fields will be part of the `/themes` endpoint exposed by Core starting from the next WP release. This PR updates the fields added by Gutenberg to follow the same semantics, as well as the callsites that use that endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Display the current theme name in the template selector of
edit-site.Since the
/themesendpoint currently only exposes thetheme_supportsfield for each theme, this PR adds a number of additional fields to it, using therest_prepare_themehook. (I also filed a WordPress/wordpress-develop#222 against Core to extend the, err, upstream endpoint accordingly so that we can eventually drop the filter.)In addition, this PR adds a new
getCurrentThemeselector and related reducer/resolver/action tocore-data(including athemesreducer for better normalization).Finally, that selector is used to render the theme name in
edit-site's template selector.The fields I've chosen to add should be sufficient to implement the on-hover previews seen at #20469 (comment):
However, this PR doesn't implement those previews yet, since we need to implement the underlying fly-out menu component first (see #20470).
Fixes part of #20469.
How has this been tested?
Screenshots
Types of changes
New feature
Checklist: