Issue 331/mention support on @ keypress #22119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Android we are discarding selections when we think they might get stripped by Aztec, so adding the space to the ends results in the selection values getting discarded.
# Conflicts: # packages/components/src/index.native.js
SergioEstevao
added
the
Mobile App - i.e. Android or iOS
SergioEstevao
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta and
youknowriad
as code owners
SergioEstevao
changed the base branch from
master
to
rnmobile/issue_331/mention_support
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
2 tasks
…_331/mention_support_trigger_on_keypress
…_on_keypress # Conflicts: # packages/rich-text/src/component/index.native.js
…mention_support_trigger_on_keypress
mchowning
reviewed
Jun 5, 2020
|
|
||
| this.handleDelete( event ); | ||
| this.handleEnter( event ); | ||
| this.handleMention( event ); |
There was a problem hiding this comment.
Just a reminder that before merging this we need to make sure our usage of capabilities and the DEV flag is consistent between here and with the mention button on the format bar.
…ort_trigger_on_keypress
2 tasks
SergioEstevao
added
[Feature] Rich Text
mchowning
force-pushed
the
rnmobile/issue_331/mention_support_trigger_on_keypress
branch
from
bf44b62 to
31d0007
Compare
…_on_keypress # Conflicts: # packages/react-native-editor/ios/Podfile.lock
|
@ceyhun do you mind giving a look to this again, now that we have updated it for all the monorepo changes? |
ceyhun
approved these changes
Jun 29, 2020
There was a problem hiding this comment.
It works great and as expected, although on Android it felt a bit slow to react when @ is pressed (1-2 seconds) for me both in emulator and in real-device.
It may be because it was running from the server and in DEV mode or because I have an old device. It'll probably be faster when bundled.
SergioEstevao
deleted the
rnmobile/issue_331/mention_support_trigger_on_keypress
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the rich text component in mobile in order to intercept any random keypress.
How has this been tested?
This can be tested by running:
npm run native iosornpm run native androidafter the demo app starts, follow these steps:mattis addedRelated PR: GB-Mobile: wordpress-mobile/gutenberg-mobile#2424
Screenshots
Types of changes
Checklist: