Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 331/mention support on @ keypress #2424

Merged
merged 12 commits into from
Jun 29, 2020
Merged

Issue 331/mention support on @ keypress #2424

merged 12 commits into from
Jun 29, 2020

Conversation

SergioEstevao
Copy link
Contributor

Fixes #331

Related PRs:

This PR changes the AztecView component to be able to intercept any keycode that is defined. It then configures uses this functionality to intercept the @ keypress and start the mention UI.

To test:

  • Start the demo app
  • Add a Paragraph block
  • Tap the @ on the keyboard
  • Check if a mention to matt is added
  • Check if the mention is only inserted if the @ is inserted with a space before or at the start of the paragraph.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added the [Type] Enhancement Improves a current area of the editor label Jun 24, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 24, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

This was referenced Jun 24, 2020
Closed
Merged
@mchowning mchowning force-pushed the issue/331_mention_support_trigger_on_keypress branch from 7e2bab3 to fc4a27b Compare June 25, 2020 19:48
@SergioEstevao
Update GB reference.
58d5bb0
@SergioEstevao
Merge branch 'develop' into issue/331_mention_support_trigger_on_keyp…
6db0188 
…ress

# Conflicts:
#	bundle/android/App.js
#	bundle/android/App.js.map
#	bundle/ios/App.js
#	bundle/ios/App.js.map
#	gutenberg
@SergioEstevao SergioEstevao requested a review from ceyhun June 26, 2020 15:42
@SergioEstevao SergioEstevao mentioned this pull request Jun 26, 2020
Merged
3 tasks
marecar3
marecar3 approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test on WPAndroid and it's working as expected!

@marecar3
Copy link
Contributor

Update: Tested on WPAndroid and WPiOS and it's working as expected!

@SergioEstevao SergioEstevao merged commit 3682e46 into develop Jun 29, 2020
@SergioEstevao SergioEstevao deleted the issue/331_mention_support_trigger_on_keypress branch June 29, 2020 22:05
@SergioEstevao SergioEstevao mentioned this pull request Jul 8, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marecar3 marecar3 marecar3 approved these changes

@mchowning mchowning Awaiting requested review from mchowning

@ceyhun ceyhun Awaiting requested review from ceyhun

Assignees
No one assigned
Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support @-mentions while editing
3 participants
@SergioEstevao @marecar3 @mchowning