-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Navigation screen] Only show appender for the currently selected block #22998
Merged
draganescu
merged 2 commits into
master
from
update/show-appender-for-current-level-only
Jun 9, 2020
Merged
[Navigation screen] Only show appender for the currently selected block #22998
draganescu
merged 2 commits into
master
from
update/show-appender-for-current-level-only
Jun 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Feature] List View
Menu item in the top toolbar to select blocks from a list of links.
[Feature] Navigation Screen
labels
Jun 8, 2020
15 tasks
Size Change: +574 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Jun 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM!
This was referenced Jun 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] List View
Menu item in the top toolbar to select blocks from a list of links.
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the navigator to only display a single appender - one related to the currently selected block:
It also proposes the following way of handling the appender for single menu items - this way there is no need for a separate "add nested menu" action:
How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: