Make accessible toolbar stable and deprecate old usage #23316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegohaz
added
[Type] Enhancement
|
Size Change: +579 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
youknowriad
added
the
Needs Dev Note
|
Cross-linking my comment #23615 (comment) in the tracking issue for experimental APIs. |
youknowriad
reviewed
Jul 16, 2020
youknowriad
reviewed
Jul 16, 2020
packages/block-editor/src/components/navigable-toolbar/index.js
Outdated
Show resolved
Hide resolved
This is actually an invalid warning as it may still be rendered inside <ToolbarGroup />
diegohaz
requested review from
ajlende,
cameronvoell,
chrisvanpatten,
etoledom,
guarani,
nerrad,
ntwb,
Soean and
talldan
as code owners
|
This is ready for review! :) |
youknowriad
approved these changes
Aug 10, 2020
There was a problem hiding this comment.
This is looking great for me.
I'd like to ensure that I understand the block author story better here (as I think it's important to include in the dev note). How does a block author add an accessible toolbar/buttons to its BlockControls?
If I'm understanding properly, there's no assumptation that a parent Toolbar exists, so we have to add a Toolbar with its children, right? And if we want to add a single button, we just use Button directly, right?
|
@youknowriad Not exactly. I updated the docs here so they're (hopefully) more clear regarding the usage of Basically you have to use either
If you use |
youknowriad
reviewed
Aug 11, 2020
tellthemachines
removed
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18619
Summary of changes in this PR:
__experimentalToolbarItemcomponent toToolbarItem.Toolbar's__experimentalAccessibilityLabelprop tolabel.Toolbarwhen used without thelabelprop (will still fallback toToolbarGroupfor backward compatibility).Toolbar,ToolbarGroup,ToolbarButtonandToolbarItemcomponents.How to test?
Make sure block toolbar and the top toolbar are working.