Replace accessibilityLabel by label on RadioGroup #25128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegohaz
changed the title
diegohaz
added
[Package] Components
diegohaz
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
|
Size Change: -14 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RadioGroupcomponent was introduced on #20805 as an experimental component with anaccessibilityLabelprop.This prop name was also used in the
Toolbarcomponent while it was experimental. But after #23316, the prop was renamed tolabelso it's consistent with other components likeButton.So I'm taking advantage of its experimental state and also updating the prop here on
RadioGroupso it's also consistent with the other components.