FSE - Follow-up to #25995: Use `WP_Theme::get_stylesheet` instead of the private property. #26275

fklein-lu · 2020-10-19T14:30:02Z

Description

As noted in this comment on PR #25995, the WP_Theme::get_stylesheet() method should be used instead of of accessing the private property.

Code like wp_get_theme()->stylesheet only works because it is implemented as part of the __get() method. PHP IDE's and code analysis tools will flag this as a pattern to avoid.

How has this been tested?

Manually tested by verifying that template parts are still correctly being displayed on the frontend.

Types of changes

PHP code style enhancement.

* Fix tagline text alignment * pass className in useBlockProps

Co-authored-by: Jon Surrell <[email protected]>

* Draft batch-processing module * committing/rudimentary API_FETCH integration * Make batch processing functional! * Roll back integration changes * Cleanup package.json * Update package-lock.json * Update terminology * yield from commitTransaction * Correct yield from * Move the comment where it belongs * First pass at enqueueItemAndWaitForResults. * Draft batch-processing module * committing/rudimentary API_FETCH integration * Make batch processing functional! * Roll back integration changes * Cleanup package.json * Update package-lock.json * Update terminology * yield from commitTransaction * Correct yield from * Move the comment where it belongs * update package-lock.json * First pass at using the new sidebars and widget endpoints. (#26086) * Draft batch-processing module * committing/rudimentary API_FETCH integration * Make batch processing functional! * Roll back integration changes * Cleanup package.json * Update package-lock.json * Update terminology * yield from commitTransaction * Correct yield from * Move the comment where it belongs * First pass at enqueueItemAndWaitForResults. * First pass at using the new sidebars and widget endpoints. * Add test for saving multiple widgets in a row * Generate better error message when creating fails * Add basic batch integration. Works off of #26205. * Allow mixing HTTP methods in a batch. * Fix disappearing data, add basic error handling. We need to get the full list of widget ids from the client, we can't use the returned widget ids from the batch because not all widgets will be dirty. Also implements basic error handling for when the batch fails. A snackbar is added with the names of the widgets that failed to save. We also now propagate a dummy error to the apiFetch callers for the requests that didn't have a validation error, but need something to short circuit their handling. * yield from the widget area saving. * Move batch-processing into edit-widgets package Co-authored-by: Adam Zieliński <[email protected]> * remove separate batch-processing package * Update batch processing tests * Resolve batch errors in a safe, well-ordered way * Fix unit tests * Wire progress indicator to specific widgets * Fix authorship after merge/rebase (1/2) * Fix authorship after merge/rebase (2/2) * Don't mark the method property as required. We don't evaluate nested defaults yet, so this caused errors. * Allow updating widgets without including the id_base or number. * Don't start GET /wp/v2/widgets?per_page=-1 if there are batch requests already in progress * Process newWidgetClientIds in correct order * Fix package.json * remove batch-processing package Co-authored-by: Timothy Jacobs <[email protected]>

The `LegacyWidgetEditHandler` component now uses the widget-types endpoint. Co-authored-by: Timothy Jacobs <[email protected]>

Addison-Stavlo

Thanks for picking this up, it looks good and works well in testing.

I noticed another place that we forgot to update from using textDomain that may be worth adding in the changes here:

gutenberg/lib/template-parts.php

Line 249 in d7014b5

    
           $template_part_string = '<!-- wp:template-part {"slug":"' . $slug . '","theme":"' . wp_get_theme()->get( 'TextDomain' ) . '"} -->' . $content . '<!-- /wp:template-part -->';

There it is still using textDomain as the theme name when creating a draft of the template part. It has been working fine in testing since for these block based themes textDomain is currently set up to be the same as the stylesheet name, but we should probably make it consistent. 😁

This let's people opt-in to a specific version of batching, and allows us to introduce in the future further flags to customize behavior.

* Fix current_parsed_blocks with inner blocks * Fix linting issues Co-authored-by: Marcus Kazmierczak <[email protected]>

* hide overlay opacity control if there is no overlay color or gradient * remove default black background color of has-background-dim class * combine selectors for overlay opacity * make overlay opacity range step congruent with available styles

…-top (#25972)

Follow up to #24599. Using the child combinator (instead of the descendant combinator) narrows the selector without increasing its specificity. This should help reduce the likelihood of a style issue occurring when a parent element has an `is-style-outline` CSS class. https://developer.mozilla.org/en-US/docs/Web/CSS/Child_combinator

* Stabilize batching endpoint as v1. * Update polyfill batching to allow for the widgets endpoint to work.

…emplate parts.

…g into fix/25995-pr-feedback

fklein-lu · 2020-10-28T12:33:30Z

Messed up that rebase, clean PR in #26539.

Addison-Stavlo · 2020-10-28T16:25:37Z

@Addison-Stavlo or @vindl – it's fine to merge approved PRs for contributors that aren't members of the project and can't really do it themselves 😄

Oops! Yes, i completely overlooked that. Will do. 👍

Use WP_Theme::get_stylesheet instead of the private property.

e5fbd7c

fklein-lu requested review from ajitbohra, Soean, spacedmonkey, talldan and TimothyBJacobs as code owners October 19, 2020 14:30

fklein-lu mentioned this pull request Oct 19, 2020

FSE Template Part rendering: Do not use text domain to detect the active theme #25856

Closed

ntsekouras and others added 11 commits October 19, 2020 17:47

Fix Site Tagline block's text alignment (#26191)

f8e10e0

* Fix tagline text alignment * pass className in useBlockProps

WordCount: Add types (#22077)

e2d8b7a

Co-authored-by: Jon Surrell <[email protected]>

Fix typo in wrapper attributes (#26282)

71d71cf

Pass all extra attributes down in get_block_wrapper_attributes (#26280)

e2300c0

Remove __experimental sidebars endpoint shim (#26288)

edc7e35

Remove WP_REST_Widget_Utils_Controller class (#26274)

849e7a5

The `LegacyWidgetEditHandler` component now uses the widget-types endpoint. Co-authored-by: Timothy Jacobs <[email protected]>

Editor: refactor PostFormatPanel to use React hooks. (#26273)

1c7eb3c

Update e2e tests README (#25985)

3ef78d4

Fix updating clientId mapping (#26290)

b9601e1

Warn about using core/batch-processing store (#26287)

d7014b5

Addison-Stavlo reviewed Oct 19, 2020

View reviewed changes

TimothyBJacobs and others added 11 commits October 19, 2020 22:25

Make batch opt-in more expressive. (#26292)

ee0085b

This let's people opt-in to a specific version of batching, and allows us to introduce in the future further flags to customize behavior.

Fix for current_parsed_blocks value when block has inner blocks (#26291)

91514a5

* Fix current_parsed_blocks with inner blocks * Fix linting issues Co-authored-by: Marcus Kazmierczak <[email protected]>

Replace wp-embed-aspect-9-6 with wp-embed-aspect-9-16 and fix padding…

52db498

…-top (#25972)

Stabilize batching endpoint as v1. (#26295)

1a63300

* Stabilize batching endpoint as v1. * Update polyfill batching to allow for the widgets endpoint to work.

Bump plugin version to 9.2.0-rc.1

48d5518

Fix #22892 and print classnames in spacer block on editor side (#23235)

c5e1b4d

Update changelog files

2dce8bb

Sort post formats alphabetically by translated name. (#26305)

741d019

gziolo added the [Feature] Full Site Editing label Oct 28, 2020

gziolo requested a review from youknowriad October 28, 2020 10:08

Fränk Klein added 3 commits October 28, 2020 13:14

Use WP_Theme::get_stylesheet instead of the private property.

48ec9da

Use stylesheet instead of the theme text domain when creating draft t…

fd6ec73

…emplate parts.

Merge branch 'fix/25995-pr-feedback' of github.com:fklein-lu/gutenber…

5cbb4e0

…g into fix/25995-pr-feedback

fklein-lu requested review from adamsilverstein, adamziel, atimmer, cameronvoell, chrisvanpatten, draganescu, ellatrix, epiqueras, etoledom, guarani, gziolo, karmatosed, kevin940726, mapk, mkaz, mkevins, nerrad, noahtallen, noisysocks, ntwb and tellthemachines as code owners October 28, 2020 12:16

fklein-lu closed this Oct 28, 2020

fklein-lu deleted the fix/25995-pr-feedback branch October 28, 2020 12:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FSE - Follow-up to #25995: Use `WP_Theme::get_stylesheet` instead of the private property. #26275

FSE - Follow-up to #25995: Use `WP_Theme::get_stylesheet` instead of the private property. #26275

fklein-lu commented Oct 19, 2020

Addison-Stavlo left a comment

fklein-lu commented Oct 28, 2020

Addison-Stavlo commented Oct 28, 2020

FSE - Follow-up to #25995: Use WP_Theme::get_stylesheet instead of the private property. #26275

FSE - Follow-up to #25995: Use WP_Theme::get_stylesheet instead of the private property. #26275

Conversation

fklein-lu commented Oct 19, 2020

Description

How has this been tested?

Types of changes

Addison-Stavlo left a comment

Choose a reason for hiding this comment

fklein-lu commented Oct 28, 2020

Addison-Stavlo commented Oct 28, 2020

FSE - Follow-up to #25995: Use `WP_Theme::get_stylesheet` instead of the private property. #26275

FSE - Follow-up to #25995: Use `WP_Theme::get_stylesheet` instead of the private property. #26275