FocalPointPicker: Fix rendering and dragging experience #28096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update improves the FocalPointPicker component to ensure that the focal point UI is visible during dragging. The solution involved removing (an old) `.is-dragging` class that was attached to the focal point UI. At some point, `.is-dragging` (globally) was forced to be `display: none !important`. Also, `InputControl` drag update stability has been improved by removing the `pointer-event: none` disabling during drag.
ItsJonQ
added
[Type] Bug
|
Size Change: -31 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
ItsJonQ
changed the title
youknowriad
reviewed
Jan 11, 2021
|
Need to fix the interaction weirdness for Safari (#25814 (comment)) Replicating in Safari
Still debugging, but this note may help others who are curious. At the start of the drag event, the
Alternatively, in Chrome, the
|
youknowriad
approved these changes
Jan 11, 2021
|
Wonderful! Thank you @youknowriad 🙏 |
|
It looks like we're having random E2E failures in this PR. (First E2E Admin 3, then E2E Admin 2) In that case, I'm going to move forward with the merge. |
This was referenced Jan 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update improves the FocalPointPicker component to ensure that the focal point UI is visible during dragging.
The solution involved removing (an old)
.is-draggingclass that was attached to the focal point UI.At some point,
.is-dragging(globally) was forced to bedisplay: none !important.Also,
InputControldrag update stability has been improved by removing thepointer-event: nonedisabling during drag.Resolves #25814
Tasks
How has this been tested?
Locally in Gutenberg and Storybook
npm run devChecklist: