Fix Cover focal point picker. #28350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
|
Size Change: +110 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
|
Thanks @jasmussen! Flagging for @jffng since this is effectively a revert of #28114. Might be worth adding some e2e coverage for the Focal Point Picker (which has recently seen some other improvements in #28096) in a follow-up PR. |
|
Let's get this in and figure out something more solid if needed. We need more coverage of all the possible combinations in the cover. I'm also seeing the matrix alignments being broken:
|
|
I removed the overflow as well. It cropped the resize handle. |
mtias
approved these changes
Jan 20, 2021
|
The following fix is separate, but would be good to land also: #28361 |
ockham
pushed a commit
that referenced
this pull request
Jan 20, 2021
* Fix Cover focal point picker. * Remove overflow.
|
Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #28114, the explicit
heightproperty was removed from the cover block.That caused a bug where content inside the cover would overflow the edges, which was fixed in #28287, which kept the height removed, but added an
overflowproperty instead.While the overflow fixed the problem with overlapping content, the height was still necessary for the focal point picker to work.
Currently:
After this patch:
I could also remove the overflow rule again, making it a full revert. But the overflow doesn't appear to be causing any issues on its own. Open to suggestions here.
While it's unfortunate we didn't catch the focal point picker issue in the last patch, I don't think fixing that is as urgent as the overflow issue. Still good to get into the next version.