-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts: Align default engines for check-engines
with the package
#28143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Bug
An existing feature does not function as intended
[Tool] WP Scripts
/packages/scripts
labels
Jan 12, 2021
gziolo
force-pushed
the
update/scripts-check-engines-default
branch
from
January 12, 2021 16:17
3fab581
to
d7601e8
Compare
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that
check-engines
uses the same default version of Node.js and npm as the@wordpress/scripts
package.Follow-up for #27934 where the minimum Node.js version was increased to 12.0 but it remained at 10.0 in the
check-engines
command.How has this been tested?
npx wp-script check-engines
There are two ways to validate:
engines
insidepackage.json
of@wordpress/scripts
.Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue).
Checklist: