Cover: Fix matrix alignment issue. #28361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -7 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
ockham
approved these changes
Jan 20, 2021
ockham
pushed a commit
that referenced
this pull request
Jan 20, 2021
For context, position absolute, combined with width/height 100% works in most cases, but is still subject to the box model, collapsing margins, and other hard-to-predict things. By replacing those with top/right/bottom/left values of zero, we set neither widths nor heights, but accomplish the same.
|
Why did I not check the frontend before merging this and before including it in 9.8 🤦♂️ With this PR:
With this PR reverted:
I'll file a revert PR and line up for a patch release 😢 |
|
We really need better (visual?) test coverage for this 😿 |
|
Ack. Sorry about that one, and thanks for all your help. |
ockham
added a commit
that referenced
this pull request
Jan 21, 2021
ockham
added a commit
that referenced
this pull request
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one pairs well with #28350, but is separate just for cleanliness.
When you use the matrix aligment, the separate background image shifts. This PR fixes that. Before:
After:
For context, position absolute, combined with width/height 100% works in most cases, but is still subject to the box model, collapsing margins, and other hard-to-predict things. By replacing those with top/right/bottom/left values of zero, we set neither widths nor heights, but accomplish the same.