Block Library: Remove no longer necessary render_callback for Cover block #31503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested review from
ajitbohra,
spacedmonkey and
TimothyBJacobs
as code owners
gziolo
added
[Package] Block library
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
|
Nice cleanup :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to: #22346
Raised in WordPress/wordpress-develop#1226 by @youknowriad:
renderd_callbackwas only added temporarily to the Cover block.playsinlineis already included inksesfor WP 5.6 and beyond:https://github.com/WordPress/wordpress-develop/blob/9ec7be02d1d5985e35caba72de784a651a0dae9d/src/wp-includes/kses.php#L406
So we should completely remove it from the Gutenberg plugin.
How has this been tested?
Ensure that
playsinlinesaves correctly in the post content for the Cover block.Checklist:
*.native.jsfiles for terms that need renaming or removal).