Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Update WordPress packages from Gutenberg 10.5 #1226

Closed
wants to merge 2 commits into from
Closed

Editor: Update WordPress packages from Gutenberg 10.5 #1226

wants to merge 2 commits into from

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented May 4, 2021

Trac ticket: https://core.trac.wordpress.org/ticket/52991

First pass, I haven't tested it yet. I plan to take care of it tomorrow.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@gziolo gziolo self-assigned this May 4, 2021
@gziolo gziolo marked this pull request as ready for review May 5, 2021 10:19
@gziolo gziolo requested a review from youknowriad May 5, 2021 10:19
@gziolo
Copy link
Member Author

gziolo commented May 5, 2021

There is one more thing left that I almost missed. For the File block, we need to add an entry point for the JS file used on the frontend and exposed under the wp-block-library-file script handle.

@gziolo
Copy link
Member Author

gziolo commented May 7, 2021

There is one more thing left that I almost missed. For the File block, we need to add an entry point for the JS file used on the frontend and exposed under the wp-block-library-file script handle.

It's a more complex task than I anticipated. Let's land the changes include already and tackle changes to the build system separately.

@gziolo
Copy link
Member Author

gziolo commented May 7, 2021

@gziolo gziolo closed this May 7, 2021
@gziolo gziolo deleted the update/block-editor-gutenberg-10.5 branch May 7, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants