ESLint Plugin: Use Jest related rules only when the package is installed #33120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psealock
added
the
Good First Review
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
gziolo
added
[Tool] ESLint plugin
|
We include all the rules for tests in the recommended config in this place: If there is no Jest installed, then probably there are no tests so we could as well ignore all those overrides. Rather than enforcing Jest as a dependency, we could ignore all Jest related rules if there is no Jest. We have a similar approach for TypeScript: What do you think about using the same technique instead? |
gziolo
changed the title
gziolo
force-pushed
the
fix/eslint-plugin-fix-jest-dependency
branch
from
8ce795f to
3d1f22f
Compare
|
@psealock, thank you for raising this issue and proposing the initial implementation 👍🏻 |
fullofcaffeine
added a commit
that referenced
this pull request
Sep 9, 2021
* trunk: [RNMobile][Embed block] Add device's locale to preview content (#33858) Update AlignmentMatrixControl docs post merge. (#34662) Chore: Update caniuse package to the latest version (#34685) Chore: Move `react-native-url-polyfill` to dev dependencies (#34687) Site Editor - add basic plugin support (#34460) ESLint Plugin: Use Jest related rules only when the package is installed (#33120) Update `@wordpress/components` package's contributing guidelines (#33960) chore(release): publish Update changelog files [RNMobile] [Embed block] Fix content disappearing on Android when switching light/dark mode (#34207) Scripts: Convert legacy entry point arguments for compatibility with webpack 5 (#34264) Update justication control in `flex` layout (#34651) Block Editor: Rename experimental prop used in `BlockControls` (#34644) Fix social links deprecation (#34639)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using
@wordpress/eslint-pluginon its own produces an error:How has this been tested?
package.json{ "name": "test-repo", "version": "1.0.0", "devDependencies": { "@woocommerce/eslint-plugin": "^1.2.0", } }test.jsfile with some violationsnpm install./node_modules/.bin/eslint test.js. This fails and you should see the error. It can be fixed by installing Jest.Types of changes
Dependency declaration for
@wordpress/eslint-pluginChecklist:
*.native.jsfiles for terms that need renaming or removal).