[RNMobile][Embed block] Add device's locale to preview content #33858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
Mobile App - i.e. Android or iOS
2 tasks
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
7 tasks
fluiddot
force-pushed
the
rnmobile/embed-block-preview-locale
branch
from
8a58473 to
28fc00c
Compare
jd-alexander
approved these changes
Sep 6, 2021
There was a problem hiding this comment.
Thanks for these changes @fluiddot I tested the behavior in Spanish and French and it worked as expected on both platforms when the Twitter provider was tested. I verified that the translations are also shown on the web as well, as seen below.
I modified the available inline previews while testing to see how Instagram & Vimeo behaved. The text of Instagram's preview was not translated so it seems not all providers support translations. Both Vimeo and Youtube do not display any words in their preview on mobile. On the web, their controls are not translated.
# Conflicts: # packages/react-native-editor/CHANGELOG.md
Yeah, looks like not all providers will have the UI translated. In the case of Instagram, I verified that it's not translated in the web version either.
|
fullofcaffeine
added a commit
that referenced
this pull request
Sep 9, 2021
* trunk: [RNMobile][Embed block] Add device's locale to preview content (#33858) Update AlignmentMatrixControl docs post merge. (#34662) Chore: Update caniuse package to the latest version (#34685) Chore: Move `react-native-url-polyfill` to dev dependencies (#34687) Site Editor - add basic plugin support (#34460) ESLint Plugin: Use Jest related rules only when the package is installed (#33120) Update `@wordpress/components` package's contributing guidelines (#33960) chore(release): publish Update changelog files [RNMobile] [Embed block] Fix content disappearing on Android when switching light/dark mode (#34207) Scripts: Convert legacy entry point arguments for compatibility with webpack 5 (#34264) Update justication control in `flex` layout (#34651) Block Editor: Rename experimental prop used in `BlockControls` (#34644) Fix social links deprecation (#34639)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3788Description
Use the device's locale in the HTML generated for the embed preview.
How has this been tested?
NOTE: For testing these changes, the embed inline preview has to be available.
NOTE: Each embed provider supports different languages so it's recommended to verify how is rendered in the web version.
Screenshots
Using Spanish as device's language:
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).