Update lock file format version to version 2 (NPM 7) #33892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
gziolo
force-pushed
the
update/npm-7.20.3
branch
from
d8d5a0c to
be84683
Compare
|
It looks like native unit tests fail locally as well, the issue looks similar to the one with
I succesfuly tested locally:
|
I debugged a bit using this draft PR @gziolo and looks like npm v6 is used on CI. I got past the above issue when I manually installed npm v7 in some of the jobs. Should we use npm7 against the v2 of the lock file? Perhaps we should bump the |
According to the npm documentation:
It would be great to have it working on CI with both npm v6 and v7. If it isn't possible we can always enforce npm v7. At the moment when you install Node v12 and v14 they both come with npm v6. Only Node 16 comes with npm 7. |
|
When I run The good news is we should be able to resolve the issue by enforcing npm v7 in GitHub actions as presented by @hypest. |
We support Node 12 and higher so we need to keep running verifications for Node v12 (Maintenance LTS), v14 (Active LTS), and also expand for v16 when it becomes Active LTS in October, see more at https://nodejs.org/en/about/releases/. It looks like this topic needs a decision-making process. If we want to switch to npm 7 we can either do it now and install it on every CI node when Node is in use, or wait until Node v16 becomes an Active LTS version and then force npm 7 only for nodes with Node 14 🙂 |
gziolo
force-pushed
the
update/npm-7.20.3
branch
from
761c46c to
2861805
Compare
gziolo
added
[Status] Blocked
gziolo
added
[Status] In Progress
This was referenced Sep 13, 2021
gziolo
force-pushed
the
update/npm-7.20.3
branch
from
2861805 to
a1466ec
Compare
gziolo
force-pushed
the
update/npm-7.20.3
branch
from
57899de to
290ec0b
Compare
gziolo
force-pushed
the
update/npm-7.20.3
branch
2 times, most recently
from
e0f5618 to
5863d20
Compare
|
Size Change: +209 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/npm-7.20.3
branch
2 times, most recently
from
9839a2c to
e85eaf6
Compare
gziolo
force-pushed
the
update/npm-7.20.3
branch
from
e85eaf6 to
cd51ffa
Compare
|
The good news is that this branch doesn't encounter issues with The remaining issues in this branch are related to missing dependencies in |
7 tasks
2 tasks
|
👋 We've addressed the |
7 tasks
|
Node v16 is now Active LTS. Is there anything still blocking this PR? |
7 tasks
We have to try again after changes are applied to forks of RN packages that use now tarballs. I'm going to extract some necessary changes to their PRs and close this PR. We will have to try again from the clean state. First PR related to |
|
I will start working on it from scratch in #36041. |
7 tasks
|
Thanks for refreshing this in a new PR @gziolo.
Just wanted to add that ideally, this change is also made in WordPress Core at the same time. Perhaps we could time this change for after WP 5.9. |
Yes, that makes a lot of sense. In the meantime, it would be great to update React Native to the latest version which might also help with a few blockers we stumbled upon so far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces #28886 (I failed to rebase the old branch from @fluiddot).
Fixes #29524.
The new lock file format is optimized for monorepos so it would simplify the process of updating dependencies for WordPress packages. More about the new lock file format in https://github.blog/2021-02-02-npm-7-is-now-generally-available/.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).