Update lock file format to version 2 (npm 8) #36041
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
changed the title
gziolo
added
[Type] Build Tooling
7 tasks
|
Size Change: 0 B Total Size: 1.08 MB ℹ️ View Unchanged
|
|
Current status:
|
gziolo
added
[Status] Blocked
gziolo
changed the title
This was referenced Dec 14, 2021
|
This branch works locally, you can test it with:
|
Closed
|
@gziolo Why is this PR a Draft? And why does it have the label "Status: Blocked"? Is there anything blocking this PR? |
It’s not working on Continues Integration. Packages aren’t properly installed from npm. It’s related to outdated package forks used with React Native code. I didn’t have time to look into it closer but it was a blocker for quite some time. |
@gziolo Heads up that I created the following PR to investigate further the issues caused by React Native dependencies. I spotted a couple of issues (referenced in this issue), the first one is related to permission issues when checking out the GitHub repository of some of the dependencies. However, after removing them, I identified new issues which don't look related to React Native. You can check the errors in the different PR checks here. |
|
Let's close in favor of #40517 that is more up to date 😄 |
I'd like to note that I created that PR only for testing purposes 😅 , but I'm happy to continue the upgrade there if you prefer. |
I would have to recreate the branch from scratch anyway because the lock file changes so often 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #36142. Alternative to #37324.
Replaces #28886 (I failed to rebase the old branch from @fluiddot).
Replaces #33892 (I failed to rebase my own branch).
The new lock file format is optimized for monorepos so it would simplify the process of updating dependencies for WordPress packages. More about the new lock file format in https://blog.npmjs.org/post/621733939456933888/npm-v7-series-why-keep-package-lockjson.html. More about other changes introduced in npm 7 in https://github.blog/2021-02-02-npm-7-is-now-generally-available/.
How has this been tested?
Checklist:
*.native.jsfiles for terms that need renaming or removal).