Lodash: Remove some _.get() from editor
#48104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
swissspidy,
flootr,
chad1008,
ntsekouras,
fabiankaegy and
brookewp
|
Size Change: +2.18 kB (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 0732876. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4185869407
|
tyxla
commented
Feb 15, 2023
|
|
||
| // Only render fields if post type supports page attributes or available templates exist. | ||
| if ( ! supportsPageAttributes ) { | ||
| if ( ! postType?.supports?.[ 'page-attributes' ] ) { |
There was a problem hiding this comment.
getPostType() could return undefined.
| ), | ||
| isPostTypeViewable: get( postType, [ 'viewable' ], false ), | ||
| hasPublishAction: getCurrentPost()._links?.[ 'wp:action-publish' ], | ||
| isPostTypeViewable: postType?.viewable, |
There was a problem hiding this comment.
getPostType() could return undefined.
| @@ -21,11 +16,7 @@ export default function PostAuthorCheck( { children } ) { | |||
| const post = select( editorStore ).getCurrentPost(); | |||
| const authors = select( coreStore ).getUsers( AUTHORS_QUERY ); | |||
| return { | |||
| hasAssignAuthorAction: get( | |||
There was a problem hiding this comment.
getCurrentPost() will always be an object:
| [ '_links', 'wp:action-publish' ], | ||
| false | ||
| ), | ||
| hasPublishAction: getCurrentPost()._links?.[ 'wp:action-publish' ], |
There was a problem hiding this comment.
getCurrentPost() will always be an object:
| [ '_links', 'wp:action-publish' ], | ||
| false | ||
| ), | ||
| hasPublishAction: getCurrentPost()._links?.[ 'wp:action-publish' ], |
There was a problem hiding this comment.
getCurrentPost() will always be an object:
| ], | ||
| false | ||
| ) | ||
| ? post._links?.[ 'wp:action-assign-' + _taxonomy.rest_base ] |
There was a problem hiding this comment.
getCurrentPost() will always be an object:
| [ 'labels', 'singular_name' ], | ||
| slug === 'category' ? __( 'Category' ) : __( 'Term' ) | ||
| ) | ||
| taxonomy?.labels?.singular_name ?? defaultName |
There was a problem hiding this comment.
taxonomy could be undefined.
| [ 'labels', labelProperty ], | ||
| slug === 'category' ? fallbackIsCategory : fallbackIsNotCategory | ||
| ); | ||
| taxonomy?.labels?.[ labelProperty ] ?? |
There was a problem hiding this comment.
taxonomy could be undefined.
| __( 'Search Terms' ) | ||
| ); | ||
| const groupLabel = get( taxonomy, [ 'name' ], __( 'Terms' ) ); | ||
| const filterLabel = taxonomy?.labels?.search_items ?? __( 'Search Terms' ); |
There was a problem hiding this comment.
taxonomy could be undefined.
| ); | ||
| const groupLabel = get( taxonomy, [ 'name' ], __( 'Terms' ) ); | ||
| const filterLabel = taxonomy?.labels?.search_items ?? __( 'Search Terms' ); | ||
| const groupLabel = taxonomy?.name ?? __( 'Terms' ); |
There was a problem hiding this comment.
taxonomy could be undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.get()from a bunch of@wordpress/editorcomponents. Most of the usages affected here are similar and that makes it easier to review as a group.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using direct access with optional chaining and nullish coalescing as an alternative.
Testing Instructions