Lodash: Remove _.get() for post type usages
#48121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
swissspidy,
flootr,
chad1008,
ntsekouras,
fabiankaegy and
brookewp
|
Size Change: +480 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 94c367f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4232858318
|
tyxla
commented
Feb 17, 2023
| @@ -35,7 +30,7 @@ export default function DevicePreview() { | |||
| hasActiveMetaboxes: select( editPostStore ).hasMetaBoxes(), | |||
| isSaving: select( editPostStore ).isSavingMetaBoxes(), | |||
| isPostSaveable: select( editorStore ).isEditedPostSaveable(), | |||
| isViewable: get( postType, [ 'viewable' ], false ), | |||
| isViewable: postType?.viewable, | |||
There was a problem hiding this comment.
All instances in this file work with a potentially nullish postType, which is why I've added some optional chaining and nullish coalescing where necessary.
I've removed the default false values in a few places where the value is already used as a boolean, because it won't make a difference.
There was a problem hiding this comment.
Defaulting to false still makes sense, because it can avoid unnecessary rerenders. If getPostType() call triggers a REST request, then postType?.viewable is initially undefined, and then becomes either true or false. The transition from undefined to false doesn't lead to any UI change, but yet it means a change of useSelect return value and triggers a wasted rerender.
There was a problem hiding this comment.
Point taken, got the false instances back in bfdd842.
tyxla
force-pushed
the
refactor/lodash-get-post-type
branch
from
bed93a3 to
6d7b435
Compare
jsnajdr
approved these changes
Feb 21, 2023
| @@ -35,7 +30,7 @@ export default function DevicePreview() { | |||
| hasActiveMetaboxes: select( editPostStore ).hasMetaBoxes(), | |||
| isSaving: select( editPostStore ).isSavingMetaBoxes(), | |||
| isPostSaveable: select( editorStore ).isEditedPostSaveable(), | |||
| isViewable: get( postType, [ 'viewable' ], false ), | |||
| isViewable: postType?.viewable, | |||
There was a problem hiding this comment.
Defaulting to false still makes sense, because it can avoid unnecessary rerenders. If getPostType() call triggers a REST request, then postType?.viewable is initially undefined, and then becomes either true or false. The transition from undefined to false doesn't lead to any UI change, but yet it means a change of useSelect return value and triggers a wasted rerender.
| @@ -83,8 +82,8 @@ export function PageAttributesParent() { | |||
| [ fieldValue ] | |||
| ); | |||
|
|
|||
| const isHierarchical = get( postType, [ 'hierarchical' ], false ); | |||
There was a problem hiding this comment.
Here we could just return isHiearchical (and parentPageLabel, too) from the useSelect callback few lines above. It already computes it.
There was a problem hiding this comment.
Good idea, reused in bfdd842.
| @@ -105,7 +100,7 @@ function PostFeaturedImage( { | |||
| const mediaUpload = useSelect( ( select ) => { | |||
| return select( blockEditorStore ).getSettings().mediaUpload; | |||
| }, [] ); | |||
| const postLabel = get( postType, [ 'labels' ], {} ); | |||
There was a problem hiding this comment.
Instead of defaulting to {}, you could write postLabels?.featured_image at the places where the object is used. It's more consistent with how postType?.labels?.whatever is used at other places, many of which are modified in this PR.
There was a problem hiding this comment.
Sure, done as part of bfdd842
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.get()from a few use cases that work with the result ofgetPostType()selector. Most of the usages affected here are similar and that makes it easier to review as a group.This PR compliments #48104.
Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using direct access with optional chaining and nullish coalescing as an alternative.
Testing Instructions