Improve block filters #48420
Closed
Improve block filters #48420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +132 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/improve-block-filters
branch
from
f260e28 to
b812d46
Compare
youknowriad
reviewed
Feb 24, 2023
| // If an alignment is not assigned, there's no need to go through the | ||
| // effort to validate or assign its value. | ||
| if ( align === undefined ) { | ||
| if ( props.attributes.align === undefined ) { |
There was a problem hiding this comment.
The problem with the change here is that the React tree of elements is different, meaning when the value of the "align" attribute changes, it will cause a "remount" of the whole block which we know can create unexpected bugs.
|
Flaky tests detected in f260e28359ada6e35cb577d9eeb6cdcbb1012723. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4263483506
|
youknowriad
reviewed
Feb 24, 2023
| }, | ||
| layoutClasses | ||
| ); | ||
| if ( ! hasLayoutBlockSupport ) { |
There was a problem hiding this comment.
Theorically, it's very hard for a block to switch between "has layout support" to "no layout support" but you also suffer the "remount" problem here if someone updates the block settings for instance by dispatching an action.
youknowriad
reviewed
Feb 24, 2023
| flex-grow: 1; | ||
| }`; | ||
| if ( ! hasChildLayout ) { | ||
| return <BlockListBlock { ...props } />; |
This was referenced Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ok, there are a couple of problems with
trunk.Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast