Align hook: improve BlockEdit filter #48422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Performance
youknowriad
reviewed
Feb 24, 2023
|
Size Change: +282 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Feb 24, 2023
youknowriad
reviewed
Feb 24, 2023
| ); | ||
| }, | ||
| [ clientId, isSelected, name ] | ||
| ); | ||
| const context = { |
There was a problem hiding this comment.
Is this context a public API, if it is, I think we should "lock" the new key somehow to make it private.
There was a problem hiding this comment.
How do you "lock" a key?
I'm thinking we should maybe create a separate boolean context for this that is private to blockEditor which can be used in the Fills and pass it down as a prop to BlockEdit for the HoCs so they don't need to call a hook.
There was a problem hiding this comment.
yeah either a separate context or store a locked function that returns the boolean in this context.
There was a problem hiding this comment.
I probably prefer the former to avoid the proliferation of contexts
There was a problem hiding this comment.
Why should we lock it though? Don't we want plugin authors to use these in their filters?
youknowriad
reviewed
Feb 24, 2023
youknowriad
reviewed
Feb 24, 2023
| }, | ||
| [ clientId, isSelected, name ] | ||
| ); | ||
| return useBlockEditContext().shouldDisplayControls; |
There was a problem hiding this comment.
useBlockControlsFill calls useDisplayBlockControls but also adds some additional checks that are now part of useDisplayBlockControls so there's probably some code to remove from useBlockControlsFill
|
Flaky tests detected in 4ffc496. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4264760720
|
|
Closing in favour of #48809. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Split out from #48420.
Only add the controls (and run related checks) which the block is selected and supports alignment.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast