-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home Link: Render Home text if there is no attribute label present #58387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjcafferkey
added
[Type] Enhancement
A suggestion for improvement.
[Block] Home Link
Affects the Home Link Block
labels
Jan 29, 2024
Size Change: +10 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ockham
reviewed
Jan 29, 2024
ockham
reviewed
Jan 30, 2024
Co-authored-by: Bernie Reiter <[email protected]>
ockham
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58307
What?
Renders default label as "Home" rather than using
useEffect
to set the attribute in the Editor client side unless user explicitly sets it on the block themselves and saves it.Why?
Using the Block Hooks API it's now possible to insert this block into the Navigation without default attributes since #57754.
As it stands, without a default
label
attribute this block won't render on the frontend.How?
This renders a default label as
Home
unless a user has set this attribute, in which case it will override the default. We are unable to set the default inblock.json
since it won't be translated.Testing Instructions
block.json
file of the Home Link block.Testing Instructions for Keyboard
Screenshots or screencast